Add pass to remove Phase gates
#1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-alec
commented
Jan 10, 2025
| @@ -2574,7 +2574,7 @@ class Circuit: | |||
| @property | |||
| def wasm_uid(self) -> str | None: | |||
| """ | |||
| :return: the unique wasm uid of the circuit | |||
| :return: the unique WASM UID of the circuit, or `None` if the circuit has none | |||
There was a problem hiding this comment.
I don't understand why this wasn't caught by the CI check previously.
pytket/binders/passes.cpp
Outdated
| @@ -679,6 +679,9 @@ PYBIND11_MODULE(passes, m) { | |||
| m.def( | |||
| "RemoveBarriers", &RemoveBarriers, | |||
| "A pass to remove all barrier instructions from the circuit."); | |||
| m.def( | |||
| "RemovePhaseOps", &RemovePhaseOps, | |||
| "A pass to remove all Phase operations from the circuit."); | |||
There was a problem hiding this comment.
The documentation should probably specify the limits of this pass, i.e. removes conditional Phases but not Phases within other boxes/controlled operations. Beyond this, the PR looks all good
willsimmons1465
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1733 .