Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build docs in release workflow. #1212

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

cqc-alec
Copy link
Collaborator

@cqc-alec cqc-alec commented Jan 12, 2024

Description

Stop building the docs in the release workflow. They are already built in the PR workflow (to check that they build successfully); and are now published separately from the docmain branch.

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@cqc-alec cqc-alec marked this pull request as ready for review January 12, 2024 09:47
@cqc-alec cqc-alec requested review from CalMacCQ and cqc-melf January 12, 2024 09:47
@cqc-melf
Copy link
Contributor

I think we are still using this to update https://cqcl.github.io/tket/pytket/api/ which is still the page of the docs google links to? I think it would be good to add a doc build for a push to docmain but that is not added yet?

@cqc-melf
Copy link
Contributor

Or a better solution would be to put a 301 to redirect and remove everything?

@cqc-alec
Copy link
Collaborator Author

Or a better solution would be to put a 301 to redirect and remove everything?

Yes, I think that's a good idea.

@cqc-alec
Copy link
Collaborator Author

Or a better solution would be to put a 301 to redirect and remove everything?

Yes, I think that's a good idea.

Will make a separate PR to do that.

@cqc-alec
Copy link
Collaborator Author

Or a better solution would be to put a 301 to redirect and remove everything?

Yes, I think that's a good idea.

Will make a separate PR to do that.

#1213

@cqc-alec cqc-alec merged commit 0fcc86d into develop Jan 12, 2024
27 checks passed
@cqc-alec cqc-alec deleted the feature/nodocsrelease branch January 12, 2024 11:28
cqc-alec added a commit that referenced this pull request Jan 17, 2024
* [infra] Fix determination of ccache path on Windows (#1192)

* Remove obsolete script. (#1179)

* Allow restriction of number of threads when building pytket using cmake. (#1180)

* Use PEP 600 manylinux containers to build pytket (#1194)

* [infra] Update versions of catch2 and rapidcheck. (#1190)

* Support python 3.12; drop python 3.9 (#1193)

* Only check pytket coverage for PRs to develop. (#1198)

* Revert "Unitary Synthesis of ChoiMixTableau for Diagonalisation (#941)"

This reverts commit ff68b3e.

Reverting because it caused significant regression in compilation
performance with
QuantinuumBackend.default_compilation_pass(optimisation_level=2) with
certain circuits composed of PauliExpBoxes.

* Bump tket version.

* Update changelog.

* Don't try to install ZX module with Python 3.12. (#1203)

* Bump tket version.

* Make the syntax of example commands more consistent between the READMEs. (#1188)

* [bugfix] Handle missing edge case in decomposition of `Rotation` (#1208)

* [feature] Accept `OpType.Phase` in circuits passed to `ZXGraphlikeOptimisation` (#1210)

* Update/copyright year (#1211)

* updtae copyright year

* update tket version

* update tket version II

* Don't build docs in release workflow. (#1212)

* Add missing `OpType.ConjugationBox` (#1209)

* Improve documentation of PassSelector. (#1214)

* Bump cachix/install-nix-action from 24 to 25 (#1216)

Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 24 to 25.
- [Release notes](https://github.com/cachix/install-nix-action/releases)
- [Commits](cachix/install-nix-action@v24...v25)

---
updated-dependencies:
- dependency-name: cachix/install-nix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alec Edgington <[email protected]>

* Update version and changelog.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: David Yonge-Mallo <[email protected]>
Co-authored-by: cqc-melf <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants