[feature] Accept OpType.Phase in circuits passed to `ZXGraphlikeOpt…

…imisation` (#1210)
CQCL · Jan 11, 2024 · 0ccaca7 · 0ccaca7
1 parent 245f3cd
commit 0ccaca7
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 8 deletions.
diff --git a/pytket/conanfile.py b/pytket/conanfile.py
@@ -32,7 +32,7 @@ def package(self):
         cmake.install()
 
     def requirements(self):
-        self.requires("tket/1.2.84@tket/stable")
+        self.requires("tket/1.2.85@tket/stable")
         self.requires("tklog/0.3.3@tket/stable")
         self.requires("tkrng/0.3.3@tket/stable")
         self.requires("tkassert/0.3.4@tket/stable")

diff --git a/pytket/docs/changelog.rst b/pytket/docs/changelog.rst
@@ -4,6 +4,10 @@ Changelog
 Unreleased
 ----------
 
+Features:
+
+* Accept ``OpType.Phase`` in circuits passed to ``ZXGraphlikeOptimisation``.
+
 Fixes:
 
 * Handle a missing edge case in decomposition of single-qubit rotations.

diff --git a/tket/conanfile.py b/tket/conanfile.py
@@ -23,7 +23,7 @@
 
 class TketConan(ConanFile):
     name = "tket"
-    version = "1.2.84"
+    version = "1.2.85"
     package_type = "library"
     license = "Apache 2"
     homepage = "https://github.com/CQCL/tket"

diff --git a/tket/proptest/src/proptest.cpp b/tket/proptest/src/proptest.cpp
@@ -54,7 +54,8 @@ using namespace tket;
   DO(NormaliseTK2)                        \
   DO(SquashRzPhasedX)                     \
   DO(CnXPairwiseDecomposition)            \
-  DO(RemoveImplicitQubitPermutation)
+  DO(RemoveImplicitQubitPermutation)      \
+  DO(ZXGraphlikeOptimisation)
 
 static const std::map<PassPtr, std::string> &pass_name() {
   // Map from PassPtr to readable name
@@ -201,7 +202,9 @@ static Architecture random_architecture() {
  * @param[in] c0 original circuit
  * @param[in] cu compliation pass having been applied to \p c0
  */
-static void check_correctness(const Circuit &c0, const CompilationUnit &cu) {
+static void check_correctness(
+    const Circuit &c0, const CompilationUnit &cu,
+    tket_sim::MatrixEquivalence equivalence) {
   RC_LOG() << "In Check Correctness" << std::endl;
 
   const Circuit &c1 = cu.get_circ_ref();
@@ -247,7 +250,7 @@ static void check_correctness(const Circuit &c0, const CompilationUnit &cu) {
     const auto u1 = tket_sim::get_unitary(c1);
     const auto u0 = tket_sim::get_unitary(c0_copy);
     RC_ASSERT(tket_sim::compare_statevectors_or_unitaries(
-        u0, m_inv_fin * u1 * m_ini));
+        u0, m_inv_fin * u1 * m_ini, equivalence));
   } catch (const Unsupported &) {
   } catch (const BadOpType &) {
   }
@@ -317,7 +320,11 @@ bool check_passes() {
             for (auto postcon : postcons) {
               RC_ASSERT(postcon.second->verify(c1));
             }
-            check_correctness(c, cu);
+            check_correctness(
+                c, cu,
+                (pass_name().at(p) == "ZXGraphlikeOptimisation")
+                    ? tket_sim::MatrixEquivalence::EQUAL_UP_TO_GLOBAL_PHASE
+                    : tket_sim::MatrixEquivalence::EQUAL);
           } else {
             RC_ASSERT(c == c1);
           }
@@ -368,7 +375,7 @@ bool check_mapping() {
           RC_LOG() << x.first.repr() << " " << x.second.repr() << std::endl;
         }
         if (applied) {
-          check_correctness(c, cu);
+          check_correctness(c, cu, tket_sim::MatrixEquivalence::EQUAL);
         } else {
           RC_ASSERT(c == c1);
         }

diff --git a/tket/src/Converters/ZXConverters.cpp b/tket/src/Converters/ZXConverters.cpp
@@ -159,7 +159,8 @@ BoundaryVertMap circuit_to_zx_recursive(
       // Spiderless ops are handled during vertex wiring
       case OpType::Barrier:
       case OpType::noop:
-      case OpType::SWAP: {
+      case OpType::SWAP:
+      case OpType::Phase: {
         continue;
       }
       case OpType::H: {