Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the unfollow button go clicky clicky #346

Merged
merged 16 commits into from
Feb 15, 2019
Merged

make the unfollow button go clicky clicky #346

merged 16 commits into from
Feb 15, 2019

Conversation

iandioch
Copy link
Member

@iandioch iandioch commented Feb 14, 2019

Closes #318.

  1. Adds a "delete follow" bit to the database service.
  • + tests
  1. Adds unfollow endpoint to follows service
  • + test
  1. Adds skinny endpoint to forward unfollows to follows service
  2. Adds logic in frontend to send unfollow request when unfollow button is clicked.
  3. Removes the alert boxes when you click the follow or unfollow button successfully (which makes it feel 100x smoother and nicer, and makes errors less scary)

@iandioch iandioch changed the title Add make the unfollow button go clicky clicky Feb 14, 2019
@iandioch iandioch marked this pull request as ready for review February 14, 2019 20:07
Copy link
Contributor

@SailSlick SailSlick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems grand

@iandioch
Copy link
Member Author

Thanks for the review fren

@iandioch iandioch merged commit c83a264 into master Feb 15, 2019
@iandioch iandioch deleted the n/unfollow_c2s branch February 15, 2019 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants