Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced deprecated scipy derivative #417

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

manoskary
Copy link
Member

This pull request introduces a new function first_order_derivative and replaces the usage of scipy.misc.derivative with this new function in the partitura package. As of scipy version 1.15 the function scipy.misc.derivative is deprecated.

@manoskary manoskary added the bug Something isn't working label Jan 20, 2025
@manoskary manoskary requested a review from sildater January 20, 2025 14:04
@manoskary manoskary self-assigned this Jan 20, 2025
@manoskary manoskary linked an issue Jan 20, 2025 that may be closed by this pull request
@sildater sildater removed their request for review January 21, 2025 14:25
Copy link
Member

@fosfrancesco fosfrancesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, more comments. But they should be fast

@fosfrancesco fosfrancesco merged commit e204c08 into develop Jan 24, 2025
3 checks passed
@fosfrancesco fosfrancesco deleted the scipy_derivative_deprecation branch January 24, 2025 13:26
@manoskary manoskary mentioned this pull request Jan 26, 2025
manoskary added a commit that referenced this pull request Feb 27, 2025
PR for Version 1.6.0.

The following changes were applied:

# Updated Merge Report

below the updated notes for this PR to include most recent changes

## PR for version 1.6.0

This new version addresses multiple changes, bug fixes and new features:

### New features
- Measure refactor for musicxml, match, midi, note array to part in #376
- Measure feature #377
- Clef feature #382
- Clef map #384 #396
- Stem direction #392 
- Support for cross staff voices in mei #397
- Improved parsing of Kern scores #413 
- Fixed import for performance pedal #399 
- Tick Units are now supported for pianoroll creation #412 
- Scores can be loaded directly for URL #404 
- Support for invisible objects in musicxml import #401 
- Support for Fingering annotations in MusicXML and MEI import/export #403 

### Bug fixes
- Corrected `get_time_maps_from_alignment` #360
- Corrected metrical strength features #364
- Corrected offsets for tied notes #366
- Fixed import issue #368
- Fixed Kern parsing #370
- Duration of Chord Notes #418 
- Corrected symbolic note duration #372
- Fixed tuplet bug #387
- Addressed sorting for enharmonic notes #407 
-  Fixes eq bug on performed notes #422
- Fixed timing-tempo change bug #427 

### Other Changes
- Added check for empty note array #361
- Improved documentation #362 #364
- Removed default voice estimation #373
- Added warning #379 
- Removed ordering in musicxml export #391
- Improved Fingering parsing in MusicXML that could result to errors #416
- Replaced Deprecated Scipy Function #417 
- Improved support for input and export in musicxml tuplet object
- New option to force add new segments #410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError with scipy version 1.15.0
2 participants