[7주차] COW-Spring-1 학습 (taewook02) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taewook02
commented
Sep 4, 2023
taewook02
commented
구현 기능 목록
차 이름을 쉼표 기준으로 나눠 문자열 리스트로 반환하는 메서드
차 이름을 쉼표 기준으로 나눠 문자열 리스트로 반환하는 메서드
자동차 이름을 입력받는 메서드
시도 횟수를 입력받는 메서드
0~9 사이의 난수 생성 후 반환하는 메서드
위치를 변경하는 메서드
wonjunYou
reviewed
Sep 6, 2023
| public class Car { | ||
|
|
||
| private final String name; | ||
| private final int MOVE_CONDITION = 4; |
There was a problem hiding this comment.
static final로 선언해주세요! 해당 변수는 필드 가장 상단에 위치시켜주세요!
| return carList; | ||
| } | ||
|
|
||
| public int getCarNumber() { |
There was a problem hiding this comment.
컬렉션을 사용하셨으니 carList.size() 를 반환하면 되지 않을까 싶습니다!
| Map<String, Integer> raceState = raceRepository.getRaceState(); | ||
| int maxValue = Collections.max(raceState.values()); | ||
| List<String> maxKeys = raceState.entrySet().stream() | ||
| .filter(entry -> entry.getValue() == maxValue) |
There was a problem hiding this comment.
요런 필터에 사용되는 조건도 메서드로 분리하면 좋겠네요!
Comment on lines
+23
to
+35
| public void run() { | ||
| ((OutputView) outputView).outputRunTitle(); | ||
| int attemptTimes = raceRepository.getAttemptTimes(); | ||
| List<Car> carList = raceRepository.getCar(); | ||
| IntStream.range(0, attemptTimes).forEach(i -> { | ||
| Map<String, Integer> raceState = carList.stream() | ||
| .peek(Car::move) | ||
| .collect(Collectors.toMap(Car::getName, Car::getPosition)); | ||
| ((OutputView) outputView).outputRunState(raceState); | ||
| raceRepository.saveRaceState(raceState); | ||
| }); | ||
| } | ||
| } |
| public class InputView implements ViewInterface { | ||
|
|
||
| public List<String> InputCarName() { | ||
| System.out.println("경주할 자동차 이름을 입력하세요.(이름은 쉼표(,) 기준으로 구분)"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.