[7주차] COW-Spring-1 학습 (KoSeonJe) #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoSeonJe
commented
Aug 31, 2023
•
KoSeonJe
commented
added 30 commits
August 29, 2023 12:33
wonjunYou
approved these changes
Sep 6, 2023
| return new Car(name); | ||
| } | ||
|
|
||
| public void moveForward() { |
There was a problem hiding this comment.
pickNumberInRange는 Car 도메인 바깥에서 이뤄지는게 적합할 것 같아요!
| import java.util.List; | ||
| import java.util.stream.IntStream; | ||
|
|
||
| public class RacingManager { |
There was a problem hiding this comment.
오 RacingGame - Manager로 이어지는 설계 아주 굿입니다 !
Comment on lines
+27
to
+29
|
|
||
|
|
||
|
|
dojinyou
reviewed
Sep 9, 2023
| @@ -0,0 +1,8 @@ | |||
| package message; | |||
|
|
|||
| public class ErrorMessage { | |||
There was a problem hiding this comment.
final , private constructor or enum 고려
| import java.util.List; | ||
| import message.ErrorMessage; | ||
|
|
||
| public class Validation { |
There was a problem hiding this comment.
Suggested change
| public class Validation { | |
| public class Validator { |
|
|
||
| public class Validation { | ||
|
|
||
| private final int CHARACTER_LIMIT =5; |
There was a problem hiding this comment.
이게 여기 있는게 맞나 모르겠다.
Suggested change
| private final int CHARACTER_LIMIT =5; | |
| private final int CHARACTER_LIMIT = 5; |
Comment on lines
+24
to
+26
| private RacingController racingController() { | ||
| return new RacingController(new RacingServiceImpl()); | ||
| } |
Comment on lines
+10
to
+11
|
|
||
|
|
| public class Application { | ||
|
|
||
| public static void main(String[] args) { | ||
| // TODO 구현 진행 |
Comment on lines
+13
to
+14
| public FrontController(InputView inputView, OutputView outputView, | ||
| RacingController racingController) { |
There was a problem hiding this comment.
Suggested change
| public FrontController(InputView inputView, OutputView outputView, | |
| RacingController racingController) { | |
| public FrontController( | |
| InputView inputView, | |
| OutputView outputView, | |
| RacingController racingController | |
| ) { |
| outputView.showRace(racingController.startRace(inputView.inputCar(), inputView.inputRound())); | ||
| outputView.showWinner(racingController.getWinner()); | ||
| } catch (IllegalArgumentException e) { | ||
| System.out.println(e.getMessage()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.