Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDING-000] Image CDN URL 구성요소 수정 #215

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

KoSeonJe
Copy link
Collaborator

@KoSeonJe KoSeonJe commented Jan 14, 2025

🚀 작업 내용

🤔 고민했던 내용

💬 리뷰 중점사항

Summary by CodeRabbit

  • 개선 사항
    • 파일 URL 생성 로직을 더욱 유연하고 일관되게 개선했습니다.
    • CDN URL 구성 방식을 최적화하여 파일 경로 처리의 안정성을 높였습니다.

@KoSeonJe KoSeonJe added 🚨긴급 신속한 처리가 필요한 이슈 🎯리팩토링 리팩토링 및 고도화 이슈 labels Jan 14, 2025
@KoSeonJe KoSeonJe self-assigned this Jan 14, 2025
Copy link

coderabbitai bot commented Jan 14, 2025

"""

워크스루

S3FileService 클래스의 getUploadedFileUrl 메서드에서 cdnUrl 문자열 생성 방식이 변경되었습니다. 기존에는 splitKey 배열의 마지막 3개 요소를 사용하여 URL을 구성했지만, 새로운 구현에서는 FILE_CDN_URL + key를 사용하여 전체 key 문자열을 포함하는 더 간단한 방식으로 변경되었습니다. 나머지 코드에는 변경 사항이 없습니다.

변경 사항

파일 변경 요약
src/main/java/ddingdong/ddingdongBE/file/service/S3FileService.java getUploadedFileUrl 메서드의 cdnUrl 생성 로직 변경: 배열의 마지막 3개 요소 대신 전체 key 사용

관련 가능성 있는 PR

제안된 레이블

D-0

제안된 리뷰어

  • wonjunYou
  • 5uhwann
    """

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 27a06ce and 8e30e5b.

📒 Files selected for processing (1)
  • src/main/java/ddingdong/ddingdongBE/file/service/S3FileService.java (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/main/java/ddingdong/ddingdongBE/file/service/S3FileService.java
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build and analyze

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@KoSeonJe KoSeonJe merged commit f2c527e into develop Jan 14, 2025
4 checks passed
@KoSeonJe KoSeonJe deleted the refactor/DDING-000 branch January 14, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯리팩토링 리팩토링 및 고도화 이슈 🚨긴급 신속한 처리가 필요한 이슈
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant