Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D3 bypass observable - stats corrected #808

Draft
wants to merge 57 commits into
base: master
Choose a base branch
from

Conversation

Giaccomole
Copy link
Contributor

Corrected a mistake in stats. See the file.

Giaccomole and others added 17 commits January 13, 2025 11:24
Signed-off-by: Orhun Ucak <[email protected]>
Signed-off-by: Orhun Ucak <[email protected]>
Signed-off-by: Orhun Ucak <[email protected]>
Signed-off-by: Orhun Ucak <[email protected]>
Signed-off-by: Orhun Ucak <[email protected]>
Signed-off-by: Orhun Ucak <[email protected]>
Signed-off-by: Orhun Ucak <[email protected]>
Signed-off-by: Orhun Ucak <[email protected]>
}).catch(error => {
console.error("Error loading CSV data:", error);
document.getElementById("donut").innerText = "Error loading data. Please check the console for details.";
});

console.log("Script execution complete");
</script>
</script>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this the reason that pre-commit complains, that it as of today expects a line break at end of file

@@ -0,0 +1,5 @@
Type,V2,V3,V4,V5,V6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should discuss a bit what we want to use as headings. I am thinking if it would be better to specify exact version like v4.2 rather than v4 (even if we have a v4 tag in git, which should point to latest v4.x release). I assume V6 refers to "latest master", but right now it is not dynamically calculated right? I.e. it refers to master at some time in the past?

(And nothing that needs to be addressed now - I am more thinking on how we want to handle it in the future. Like using a "tag" master-2025-02-06, commit-sha-id or something similar to show origin if it is manually created, or just "master" if it is generated on the fly on merge)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+I assume V6 refers to "latest master", it refers to master at some time in the past?

  • Yes, it refers to the point in time where the datafile behind the graph was created. The .csv is not dynamically created yet, but the graph now renders new radio buttons for new versions (like V7 in the future) relying on the .csv

I built an automated logic on this .csv as of last week, but it waits for some review. Here is the simplified code:

if 'Vehicle.VersionVSS.Major' in row['Signal'] and row['Default'] > 5:
        major_version = int(row['Default'])

if (major_version is not None):
    
    type_counts 
    column_name = f'V{major_version}'
    version_cols = [col for col in latest.columns if col.startswith('V')]
    for i in range(len(version_cols) - 1):
        v1 = int(version_cols[i][1])
        v2 = int(version_cols[i+1][1])
        if v2 != v1 + 1:
            print(f"MISSING VERSION: V{v1+1}")

So retrospectively for the first 5 versions, I just collected the VX.0 from the documentation, stays as a static template in the code. But starting with V6 this logic counts the types dynamically and concatonates. But keeps the heading as the major version number, even if the minor version changes. I could change this to specify the minor version on the chart. But it could result in something like:

V2 V3 V4 V5 V6.12 V7.3 V8.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS: I built new exporters to vss-tools and modified the docgen.yml in VSS GitHub Actions to generate this in each commit.

https://github.com/Giaccomole/vehicle_signal_specification/tree/Stats-git-actions
https://github.com/Giaccomole/vss-tools-statistics-py-scripts/tree/stat-scripts

@erikbosch
Copy link
Collaborator

MoM:

  • Please review

Giaccomole and others added 29 commits February 12, 2025 14:59
Signed-off-by: Orhun Ucak <[email protected]>
Signed-off-by: Orhun Ucak <[email protected]>
Signed-off-by: Orhun Ucak <[email protected]>
Signed-off-by: Orhun Ucak <[email protected]>
* applying instances to ObstacleDetection, other Obstacle attributes and adding Adaptive to CruiseControl

Signed-off-by: tguild <[email protected]>
Signed-off-by: Erik Jaegervall <[email protected]>
Co-authored-by: tguild <[email protected]>
Signed-off-by: Orhun Ucak <[email protected]>
Signed-off-by: Erik Jaegervall <[email protected]>
Signed-off-by: Orhun Ucak <[email protected]>
Signed-off-by: Orhun Ucak <[email protected]>
Signed-off-by: Orhun Ucak <[email protected]>
Signed-off-by: Orhun Ucak <[email protected]>
* Clarify VSS expectations on read/write

Signed-off-by: Erik Jaegervall <[email protected]>
Co-authored-by: Daniel Alvarez-Coello <[email protected]>
Signed-off-by: Orhun Ucak <[email protected]>
Signed-off-by: Erik Jaegervall <[email protected]>
Signed-off-by: Orhun Ucak <[email protected]>
Signed-off-by: Orhun Ucak <[email protected]>
Signed-off-by: Orhun Ucak <[email protected]>
Signed-off-by: Orhun Ucak <[email protected]>
Signed-off-by: Orhun Ucak <[email protected]>
Signed-off-by: Orhun Ucak <[email protected]>
Signed-off-by: Orhun Ucak <[email protected]>
Signed-off-by: Orhun Ucak <[email protected]>
Signed-off-by: Orhun Ucak <[email protected]>
@Giaccomole Giaccomole marked this pull request as draft February 13, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants