Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of typo in spec/Body/WiperSystem.vspec #807

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

Herrmann-Alexander
Copy link
Contributor

@Herrmann-Alexander Herrmann-Alexander commented Feb 4, 2025

This pull request just corrects a typo. Sorry for the many pull requests I closed but I have problems with sign off.

@erikbosch
Copy link
Collaborator

Thanks for the Pull-Request. The failing DCO check is not critical. It is cause by a minor mismatch. If looking at the DCO check it complains like this:

Commit sha: [674626e](https://github.com/COVESA/vehicle_signal_specification/pull/807/commits/674626e100d0c553ce0b5e116ae56ee0df390a24), Author: Herrmann-Alexander, Committer: GitHub; Expected "Herrmann-Alexander [[email protected]](mailto:[email protected])", but got "Alexander Herrmann [[email protected]](mailto:[email protected])".

It is not obvious, but if one fetches your commit and show for example with gitk one can see a missmatch between the author field (Herrmann-Alexander) and the signoff (Alexander Herrmann) which causes the DCO check to complain. As the fix in the PR is trivial we could ignore the failure, so do not feel obliged to fix it.

Author: Herrmann-Alexander <[email protected]>  2025-02-04 12:45:53
Committer: GitHub <[email protected]>  2025-02-04 12:45:53
Parent: 19ff0656d21c85db15d2882417e5b24d0037bce8 (Update pre-commit version)
Branch: pr807
Follows: v4.0
Precedes: 

    Correction of typo in spec/Body/WiperSystem.vspec
    
    Signed-off-by: Alexander Herrmann <[email protected]>

@erikbosch erikbosch merged commit 41fa9f2 into COVESA:master Feb 6, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants