Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nonexistent TEROS 3 and 4 at PTR-W #225

Merged
merged 4 commits into from
Jan 3, 2025
Merged

Remove nonexistent TEROS 3 and 4 at PTR-W #225

merged 4 commits into from
Jan 3, 2025

Conversation

bpbond
Copy link
Member

@bpbond bpbond commented Dec 31, 2024

Closes #210

@bpbond bpbond requested a review from stephpenn1 December 31, 2024 19:25
Copy link
Member

@stephpenn1 stephpenn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you edited PTR UP instead of W here?

@@ -48,11 +48,14 @@ Compass_PTR_UP_313,TerosTableA,PB,PTR,UP,TEROS12,,,,,,
Compass_PTR_UP_313,TerosTableA,Format,PTR,UP,TEROS12,,,,,,
Compass_PTR_UP_313,TerosTableA,Statname,PTR,UP,TEROS12,,,,,,
Compass_PTR_UP_313,TerosTableA,BattV_Avg,PTR,UP,TEROS12,A,,,,battery_voltage,
Compass_PTR_UP_313,TerosTableA,"TerosA({1:4},1)",PTR,UP,TEROS12,A,{1:4},,,soil_vwc_10cm,
Compass_PTR_UP_313,TerosTableA,"TerosA({1:2},1)",PTR,UP,TEROS12,A,{1:2},,,soil_vwc_10cm,
Compass_PTR_UP_313,TerosTableA,"TerosA({3:4},1)",PTR,UP,TEROS12,A,{3:4},,,,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be at PTR W and not UP

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh crap 😬 thank you

Compass_PTR_UP_313,TerosTableA,"TerosA({5:6},1)",PTR,UP,TEROS12,A,{5:6},,,soil_vwc_30cm,
Compass_PTR_UP_313,TerosTableA,"TerosA({1:4},2)",PTR,UP,TEROS12,A,{1:4},,,soil_temp_10cm,
Compass_PTR_UP_313,TerosTableA,"TerosA({1:2},2)",PTR,UP,TEROS12,A,{1:2},,,soil_temp_10cm,
Compass_PTR_UP_313,TerosTableA,"TerosA({3:4},2)",PTR,UP,TEROS12,A,{3:4},,,soil_temp_10cm,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This extra row necessary re: above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea where my head was when I made these changes, sorry

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the post-holiday fog!!

@bpbond
Copy link
Member Author

bpbond commented Jan 3, 2025

Fixed I hope 🤞 -- thanks for your careful check

Copy link
Member

@stephpenn1 stephpenn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for working on this

@bpbond bpbond merged commit b51b135 into main Jan 3, 2025
1 check passed
@bpbond bpbond deleted the ptrw34 branch January 3, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad vwc sensor 4 at PTR-W?
2 participants