BFD-3817: Create Patient StructureDefinition + YAML #2536
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-dzeda
requested review from
mjburling,
dondevun,
aschey-forpeople and
malessi
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BFD-3817
What Does This PR Do?
This PR creates the first artifacts for the BFD IDR POC. Specifically, it defines two StructureDefinitions to encapsulate the data that will be used to create the Patient resource, as well as some base yamls that will be used in schema artifacts for the postgres db + data dictionary generation. It also memorializes some of the sample queries we can use to pull data from IDR.
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
Directory structure - do we have objections to the current directory structure? This is greenfield, so please speak up!
Any commentary regarding conventions used in the definitions
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependencies
Modifies any security controls
Adds new transmission or storage of data
Any other changes that could possibly affect security?
I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (
@sb-benohe) approval.)Validation
Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.
Validation for this PR is not necessary, the follow-on (actual mapping) has AC related to validation, and any issues discovered from this PR will inherently be addressed by the next one.