BFD-3761: Enable RDS observability features for RDS Autoscaling Reader Nodes #2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malessi
requested review from
mjburling,
dondevun and
aschey-forpeople
as code owners
malessi
commented
Jan 3, 2025
malessi
changed the title
malessi
commented
Jan 7, 2025
aschey-forpeople
approved these changes
Jan 8, 2025
dondevun
approved these changes
Jan 14, 2025
malessi
deleted the
alessio/BFD-3761__enable-rds-observability-at-cluster
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BFD-3761
What Does This PR Do?
This PR updates our IaC to enable Cluster-level Performance Insights and Enhanced Monitoring for our RDS DB Instances. As these observability features have been enabled at the Cluster-level, autoscaled reader Instances will inherit these settings and be created with Performance Insights and Enhanced Monitoring enabled.
Note that, once this PR is merged, we will need to manually enable both Performance Insights and Enhanced Monitoring at the Cluster level for our established Clusters. This is necessary, as the latest Terraform AWS Provider does not properly support enabling both Performance Insights and Enhanced Monitoring for Aurora Clusters. This will only need to be done once, and then if we must re-create any of our Clusters the changes in this PR will automatically enable Performance Insights and Enhanced Monitoring.
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependenciesModifies any security controlsAdds new transmission or storage of dataAny other changes that could possibly affect security?I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (
@sb-benohe) approval.)Validation
Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.
terraform applying these changes to the ephemeral environment3761-test, verifying that:3761-test, verifying that: