Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: travis testing #33

Merged
merged 1 commit into from
Oct 12, 2017
Merged

feat: travis testing #33

merged 1 commit into from
Oct 12, 2017

Conversation

Freyert
Copy link

@Freyert Freyert commented Sep 4, 2017

unit tests run on PRs.

After looking at the org.cellocad.MIT.dnacompiler.Permute class for 15 or so minutes I couldn't really make heads or tales of it so I just wrote a pretty lame unit test that just works (Java is not my native language ;p). If someone can give me pointers on how to make the unit test more useful I would like that :).

If you've never heard of Travis, it's the bees knees for many reasons:

  1. Anytime someone makes a PR it will run your unit testing suite to verify the PR does not contribute any regressions in the code.
  2. Simple to verify version compatibility as desired in Cello doesn't work well with Java 8 #29.
  3. Free for open source projects, and used by loads.

unit tests run on PRs.
@Freyert
Copy link
Author

Freyert commented Sep 4, 2017

Also, your code base, at least the really interesting bits, seem to all be functions rather than methods with side effects. Therefore, unit testing will give you significant gains in terms of project velocity and quality.

@Freyert
Copy link
Author

Freyert commented Sep 4, 2017

You will have to create a Travis account for your organization though.
https://docs.travis-ci.com/user/getting-started/

@Freyert
Copy link
Author

Freyert commented Sep 12, 2017

@bder who is maintaining this project?

@Freyert
Copy link
Author

Freyert commented Sep 13, 2017

@PrashantVaidyanathan @tim-tx any interest in this PR?

@PrashantVaidyanathan
Copy link
Contributor

@Freyert Apologies for the late reply. We do plan to have some sort of CI (and Travis is a top contender for this). We are currently restructuring some of our code. So we might accept this PR in a couple of days.

@Freyert
Copy link
Author

Freyert commented Sep 14, 2017

@PrashantVaidyanathan great :) can't wait to see it. This is a very exciting project. I'd love to help out any way I could.

@tim-tx tim-tx changed the base branch from master to develop October 12, 2017 19:36
@tim-tx tim-tx changed the base branch from develop to master October 12, 2017 19:37
@tim-tx tim-tx merged commit 213b25a into CIDARLAB:master Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants