29 feat apply changes to use workflow pipelines270 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ines Schedules client created to handle all operations related to schedules
confgis commands added so the cli can work with the new version of pipelines(^2.7.0)
shinybrar
requested changes
May 8, 2024
There was a problem hiding this comment.
- Deprecate v1 logic, instead use the v2 logic for the pipelines command
- Remove the requirement for the -n flag from
workflow config ls <NAME> - Change the banner to be
Workflow Configfromworkflow configcommand - Don't use the term children anywhere, call them
pipelineswhich the user expects and understands, and also add a small help italic section, saying, explore withworkflow piplienes - Split command for pipelines and configs.
- Improve the emojis shown as status fields,
- Deprecate, the use of
-pfromworkflow configs psonly use instead move the functionality to `workflow configs pipelinesworkflow pipelines [NAME] ls - Change all
-dshorthand altogether, while keeping the--details
* feat(workspaces/tutorial.yml): adding tutorial workspace * feat(workspaces/tutorial.yml): adding baseurl for configs
confgis commands added so the cli can work with the new version of pipelines(^2.7.0)
…ttps://github.com/CHIMEFRB/workflow into 29-feat-apply-changes-to-use-workflow-pipelines270
Tests added for pipelines client on HTTPContext.
Adding steps for: starting docker services needed for tests; setting development workspace and killing services after tests are completed.
|
@shinybrar all changes requested were adressed, I also added more tests and some changes on the |
Logging info about actual workspace being used.
* fix(cli/workspace.py): changing filename for active workspace * feat(workflow/http/context.py): adding validator function for workspace field * fix(workspace): fixed workspace cli commands and suppressed UserWarning from pydantic_settings --------- Co-authored-by: Shiny Brar (he/il) <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
confgis commands added so the cli can work with the new version of pipelines(^2.7.0)
Tests added for pipelines client on HTTPContext.
Adding steps for: starting docker services needed for tests; setting development workspace and killing services after tests are completed.
…ttps://github.com/CHIMEFRB/workflow into 29-feat-apply-changes-to-use-workflow-pipelines270
… prefixing versioning
…ttps://github.com/CHIMEFRB/workflow into 29-feat-apply-changes-to-use-workflow-pipelines270
|
@shinybrar This PR is ready for merging |
shinybrar
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.