Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robust Quotient with cpp_int #5937

Merged
merged 134 commits into from
May 6, 2022

Conversation

danston
Copy link
Contributor

@danston danston commented Aug 27, 2021

This PR provides a benchmark that compares different exact number types available in CGAL and robustifies the new option that is Quotient<boost::multiprecision::cpp_int> by providing a better/faster version of the to_interval() function with tighter intervals.

The results of the benchmark are available here.

Currently, we have three different versions:

  • one based on gmpzf (passes tests but not NEF benches)
  • one based on boost (passes tests but not NEF benches)
  • one based on cpp_rational (stable, works for all benches / tests)

TODO:

  • Remove changes from this commit: 6e41cd5 ---> DONE in 4bd7049
  • Remove benchmark data?

Release Management

  • Affected package(s): Number_types
  • Issue(s) solved (if any): fix How to robustify to_interval(Quotient) #5928
  • Feature/Small Feature (if any): Small Feature
  • Link to compiled documentation (obligatory for small feature): docs
  • License and copyright ownership: no change

@sloriot sloriot force-pushed the Number_types-add_benchmarks-danston branch from 363a90d to 7e987e5 Compare May 3, 2022 09:13
@sloriot sloriot removed Not yet approved The feature or pull-request has not yet been approved. TODO labels May 5, 2022
@sloriot
Copy link
Member

sloriot commented May 5, 2022

Successfully tested in CGAL-5.5-Ic-77

If I look at the table, it seems that boost 1.79 is not tested, only 1.80 is one 3 plateforms.

@lrineau
Copy link
Member

lrineau commented May 6, 2022

Should we test specifically Boost 1.79? On ArchLinux, I expect the package will be updated soon. Fedora Rawhide is still lagging behind at 1.76 for unknown reasons (Fedora seems shy on updates of Boost).

We could update Boost on Sosno or Christo, at least for one of the test platform? @janetournois Is that easy?

@lrineau lrineau self-assigned this May 6, 2022
@lrineau lrineau added rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' and removed Under discussion labels May 6, 2022
@lrineau lrineau merged commit 8f233c2 into CGAL:master May 6, 2022
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label May 6, 2022
@lrineau lrineau deleted the Number_types-add_benchmarks-danston branch May 6, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to robustify to_interval(Quotient) Default rational type without GMP/LEDA
5 participants