fix: refresh ursadb page and add alert about successful submit #448
Conversation
| @@ -130,11 +269,14 @@ class IndexPageInner extends Component { | |||
| <div className="my-2">{`Newest file in the queue: ${this.state.newestFile}`}</div> | |||
| )} | |||
| {this.state.oldestFile && ( | |||
| <div className="my-2">{`Oldest file in the queue`}</div> | |||
| <div className="my-2">{`Oldest file in the queue: ${this.state.oldestFile}`}</div> | |||
| @@ -130,11 +269,14 @@ class IndexPageInner extends Component { | |||
| <div className="my-2">{`Newest file in the queue: ${this.state.newestFile}`}</div> | |||
There was a problem hiding this comment.
Looking at it more deeply, the message looks like:
Newest file in the queue: 2025-03-04T12:58:25.030027
The date format is a bit over the top (I know it's the ISO format). JS is not very good at formatting dates, but maybe we
can convert it to 2025-03-04 12:58 at least?
| fileOrFiles(length) { | ||
| return `file${length > 1 ? "s" : ""}`; | ||
| } |
There was a problem hiding this comment.
Nice, I wondered about suggesting this refactoring in the previous PR.
But it's usually handled a bit differently, with a helper like pluralize:
const pluralize = (count, noun) =>
`${count} ${noun}${count !== 1 ? "s" : ''}`;
This is a bit more generouns, as you can use it for things other than file. More importantly, you don't have to do
${this.state.alertShowFileLen} ${this.fileOrFiles(this.state.alertShowFileLen)}!
and instead can just
${pluralize("files", this.state.alertShowFileLen}}!
which is nice I guess
| )} | ||
| {this.state.alertShowCleared && ( | ||
| <IndexClearedPage | ||
| msg={`Successfully cleared ${ |
There was a problem hiding this comment.
Successfully cleared false file from queue default!
I think the variable here should be alertShowCleared?
| {`Add to queue${ | ||
| fileLen > 0 | ||
| ? ` (${fileLen} file${ | ||
| fileLen > 1 ? "s" : "" | ||
| })` | ||
| ? ` (${fileLen} ${this.fileOrFiles( | ||
| fileLen | ||
| )})` | ||
| : "" |
There was a problem hiding this comment.
The same comment about pluralize here - it will work if you reorder it to add N files to queue which also makes it a bit more idiomatic english
| top: 50%; | ||
| left: 50%; | ||
| transform: translate(-50%, -50%); | ||
| z-index: auto; |
There was a problem hiding this comment.
isn't z-index: auto the default value? Unless there's some inheritance going on here.
Your checklist for this pull request
What is the current behaviour?
Currently theres no feedback to user about successful submit to UrsaDB page.
What is the new behaviour?
This PR introduces new alert about successful POST request and clears form upon submission
Test plan
Click through new page and check for any unexpected behavior
Closing issues
fixes #issuenumber