-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to artic v1.5.3 (medaka to clair3) #78
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laura-bankers
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed and ready to merge
laura-bankers
approved these changes
Nov 15, 2024
laura-bankers
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #71 and #75
Aim, context, and functionality 🎯
SC2_ont_assembly.wdl: Update artic v1.2.4 to v1.5.3. This release of the artic pipeline comes with several significant updates (see artic-network/fieldbioinformatics#137), most notably switch from Medaka to clair3.
Workflow Changes ✅
Upstream Effects
None
Input Changes
medaka_model
tomodel
Output Changes
Version capture file: task name change
Medaka
tocall_consensus_artic
and removed mentions of medaka.Downstream Effects
None (will do patch release to not cause problems with BigQuery transfers)
Testing 🛠️
test_cov_2205_grid
Test(s) performed:
Compared results between branch and current release.
Results (including if the results matched the expected results):
Theiavalidate and other results stored on GCP in validation/CDPHE-SARS-CoV-2/sb-clair3
longshot
error (no assembly output) in original results but now no error and assembly is output because of the removal oflongshot
.bcftools consensus
for the three samples that failed for this reason in the original dataset. FASTA is now output for the three samples.Developer Checklist 👷♀️
Reviewer Checklist 🔍