Updating user management flyway migrations #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 53.72% | 938/1746 |
| 🔴 | Branches | 53.66% | 293/546 |
| 🔴 | Functions | 52.6% | 192/365 |
| 🔴 | Lines | 53.79% | 881/1638 |
Test suite run success
72 tests passing in 9 suites.
Report generated by 🧪jest coverage report action from 0c10c5e
robertandremitchell
requested review from
fzhao99,
katyasoup and
johanna-skylight
|
not entirely sure what is happening with these errors...I originally tried just editing the 5th migration, and thought to instead use a new 7th migration, but still running into the same errors... |
johanna-skylight
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
This updates the user management flyway migrations to be in-line with the new ERD for user migrations: https://app.diagrams.net/#G1E5F9_cakvji46qRMMa0lGOZiaAXnJa5M#%7B%22pageId%22%3A%22WHVhyQuvTKeJfM7__wGX%22%7D
This is necessary to ensure that the user migration work is able to update/manager usergroups data.
Other minor note:
useris a reserved keyword, which is why the table is calledusers. We have a mix of tables in the singular, and some in the plural; not sure if we have we want to have a rule around that, or if it matters materially. Just a nit I noticed when reviewing the ERD.Related Issue
Fixes #361, #362
Additional Information
Anything else the review team should know?
Checklist