Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JAVA_OPTS_APPEND from docker compose #351

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

robertandremitchell
Copy link
Collaborator

PULL REQUEST

Summary

Removing arguments from docker-compose.yml that stop keycloak from starting up:

keycloak-1         | Appending additional Java properties to JAVA_OPTS
keycloak-1         | Unrecognized VM option 'UseSVE=0'
keycloak-1         | Error: Could not create the Java Virtual Machine.
keycloak-1         | Error: A fatal exception has occurred. Program will exit.
keycloak-1 exited with code 0

I think the select-realm.sh assignment of JAVA_OPTS_APPEND if m4 should be sufficient, but I'm not entirely sure.

Related Issue

Fixes #

Additional Information

Anything else the review team should know?

Checklist

  • Descriptive Pull Request title
  • Link to relevant issues
  • Provide necessary context for design reviewers
  • Update documentation

@robertandremitchell robertandremitchell marked this pull request as ready for review February 7, 2025 14:52
Copy link

github-actions bot commented Feb 7, 2025

Coverage report for ./query-connector

St.
Category Percentage Covered / Total
🔴 Statements 53.8% 941/1749
🔴 Branches 53.31% 290/544
🔴 Functions 52.47% 191/364
🔴 Lines 53.87% 883/1639

Test suite run success

72 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from b7a59c3

@fzhao99 fzhao99 closed this Feb 7, 2025
@fzhao99 fzhao99 deleted the rob/hotfix/remove-java-opts branch February 7, 2025 17:07
@fzhao99 fzhao99 restored the rob/hotfix/remove-java-opts branch February 7, 2025 17:07
@fzhao99 fzhao99 reopened this Feb 7, 2025
@robertandremitchell robertandremitchell merged commit 52ff4bc into main Feb 10, 2025
20 checks passed
@robertandremitchell robertandremitchell deleted the rob/hotfix/remove-java-opts branch February 10, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants