Landing page semantic enhancements #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanna-skylight
requested review from
fzhao99,
nickclyde,
katyasoup and
robertandremitchell
johanna-skylight
changed the title
…b.com/CDCgov/dibbs-query-connector into jd/landing-page-semantic-enhancements Merged with latest code in main
fzhao99
approved these changes
Feb 3, 2025
johanna-skylight
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
This PR addresses 3 small items:
<p>. It also makes necessary changes to turn the landing page into a server component (removes 'use client' directive).Please see below new content structure
Fixes run time exception in the results page for queries that get triggered without any search criteria on step 1.
Migrates links in the header to nextjs element so changes in routes don't do a full page reload. (If this was intentional please let me know and will revert this change).
Related Issue
Fixes # No ticket as this was my first small task to get familiar with the code and development process
Additional Information
Anything else the review team should know?
Checklist