Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Keycloak to ECS #321

Merged
merged 43 commits into from
Feb 6, 2025
Merged

Add Keycloak to ECS #321

merged 43 commits into from
Feb 6, 2025

Conversation

nickclyde
Copy link
Member

PULL REQUEST

Summary

Deploy keycloak to ECS so that our deployed app has an identity provider. Do this by building our own custom keycloak docker image with the seeded realm already imported.

Related Issue

Fixes https://linear.app/skylight-cdc/issue/QUE-154/deploy-keycloak-to-ecs

@linear Linear
Copy link

linear bot commented Jan 27, 2025

QUE-154 Deploy Keycloak to ECS

nickclyde and others added 26 commits January 28, 2025 15:14
@nickclyde
Add relative path to keycloak Dockerfile
b6026e1
@nickclyde
Set relative path env var in terraform instead
b836e25
@nickclyde
Beef up keycloak VM
9f24dd7
@nickclyde
Add proxy headers
fd0b845
@nickclyde
Add auth variables
e0e54d8
@nickclyde
Merge branch 'main' into nickclyde/keycloak-terraform
ecd4096
@nickclyde
Oops forgot to add vars to ecs_terraform workflow
c7570b1
@nickclyde
Remove trailing whitespace
ed5935a
@nickclyde
Squash merge main into nickclyde/keycloak-terraform
e713a84
@shanice-skylight
removed trailing whitespace
1f8e9e4
@nickclyde
Merge branch 'main' into nickclyde/keycloak-terraform
1f36027
@nickclyde
Re-enable sign in button in header
325b436
@nickclyde
Fix format call
8a034fc
@nickclyde
Merge branch 'main' into nickclyde/keycloak-terraform
6df0f46
@nickclyde
Merge branch 'main' into nickclyde/keycloak-terraform
753db84
@nickclyde
More env var changes
ed7efa3
@nickclyde
Add hostname and default keycloak issuer
b95a8d7
@nickclyde
Remove hostname that was dumb
e4542a0
@nickclyde
Ugh whitespace
e383899
@nickclyde
Rework auth variable names, add AUTH_URL
8e573a1
@nickclyde
Add keycloak import files for each env and selection script
58e2dbe
@nickclyde
Run chmod as root during build
b353faa
@nickclyde
Merge branch 'main' into nickclyde/keycloak-terraform
21e9973
@nickclyde
Add some debugging to select-realm.sh
2e3e99b
@nickclyde
Make sure keycloak files are copied properly
b03aa96
@nickclyde
Make terraform workflow replace all docker images
12580e9
robertandremitchell
robertandremitchell reviewed Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@robertandremitchell robertandremitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly good! the m4 stuff was throwing off my poor m3 computer, but I think there should be a way to move that to a shell script / build of Dockerfile.keycloak until the m4 issues with java/keycloak are resolved.

query-connector/keycloak/select-realm.sh Show resolved Hide resolved
shanice-skylight
shanice-skylight approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@shanice-skylight shanice-skylight left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deployed this branch to dev and terraform plan and apply resulted in expected configurations. LGTM 🚀

@nickclyde nickclyde merged commit 8915a57 into main Feb 6, 2025
11 checks passed
@nickclyde nickclyde deleted the nickclyde/keycloak-terraform branch February 6, 2025 21:49
katyasoup pushed a commit that referenced this pull request Feb 11, 2025
@nickclyde @shanice-skylight @katyasoup
Add Keycloak to ECS (#321)
30a7313 
Co-authored-by: shanice-skylight <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertandremitchell robertandremitchell robertandremitchell left review comments

@shanice-skylight shanice-skylight shanice-skylight approved these changes

@fzhao99 fzhao99 Awaiting requested review from fzhao99

@katyasoup katyasoup Awaiting requested review from katyasoup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickclyde @robertandremitchell @shanice-skylight