Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDWA-OCR-97] Benchmark tests and action #100

Merged
merged 19 commits into from
May 22, 2024

Conversation

derekadombek
Copy link
Collaborator

@derekadombek derekadombek commented May 2, 2024

Pull Request

#97

https://cdcgov.github.io/IDWA/dev/bench/

Description

[Provide a brief description of the changes implemented in this pull request.]

Related Issues

[Link any related issues or tasks from your project management system.]

Additional Notes

[Add any additional context or notes that reviewers should know about.]

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.
  • I have notified teammates in the review thread to build awareness.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@derekadombek derekadombek self-assigned this May 2, 2024
@derekadombek derekadombek marked this pull request as draft May 2, 2024 14:49
@derekadombek derekadombek marked this pull request as ready for review May 2, 2024 15:47
@derekadombek derekadombek requested a review from zdeveloper May 2, 2024 15:47
Copy link
Contributor

@zdeveloper zdeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you!

@derekadombek derekadombek added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit 01fcdfb May 22, 2024
2 checks passed
@derekadombek derekadombek deleted the OCR-97-benchmark-test-results branch May 22, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants