-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build tool update #79
Conversation
…ise just install.
… activation script actually exists
Added a few more things.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing it with cdat_info (which is a noarch, and conda-forge pkg), conda-rerender and conda-build passed, and the build creates
/home/circleci/project/linux_build/miniconda/conda-bld/noarch/cdat_info-8.2.2020.06.05.23.39.gcac191d-pyh9f0ad1d_0.tar.bz2
but when we try to do upload, we did: conda build --output to get the package name, and it is returning: cdat_info-8.2.2020.06.05.23.39.gcac191d-py_0.tar.bz2
build_tools/conda_build.py
Outdated
|
||
if args.do_rerender: | ||
ret, repo_dir = clone_repo(organization, repo_name, branch, workdir) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I had clone_repo() here is because doing rerendering will overwrite .circleci/config.yml.
The repo will be cloned to /<repo_name>.
If I accidentally set to the parent directory of my repo where I ran Makefile from, clone_repo() will overwrite my repo.
so it is better to put a check somewhere that should not be the same as the parent directory of the repo where I ran 'make' from.
build_tools/conda_build.py
Outdated
|
||
if args.do_build: | ||
status = build_in_local_repo(repo_dir, args.build_version) | ||
status = build_in_local_repo(repo_dir=repo_dir, py_version=args.build_version, **kwargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comments apply to both build_in_local_repo() and build_in_local_feedstock().
Currently when we do conda build, it gets the branch of the repo, which means if I do local changes, I have to commit to the branch and push it to github. Is there any way we can make 'conda build ..' to just use whatever we have in the work repo?
Build tool update.2 --- use **kwargs
Adds some new cli arguments:
--no-check-uptodate
is set when callingconda smithy rerender
, this handles a situation when conda-smithy or conda-forge-pinning are not sync in the environment.