Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedstock recipe #77

Merged
merged 11 commits into from
May 1, 2020
Merged

Feedstock recipe #77

merged 11 commits into from
May 1, 2020

Conversation

muryanto1
Copy link
Member

added copy_file_from_repo_recipe() which is called when building a project that has a corresponding feedstock repo (i.e. it is a conda-forge package).
This function is called from build_tools/conda_build.py to copy recipe/build.sh and recipe/conda_build_config.sh from repo to feedstock repo if they exist.
This is to accomodate cases where we are making changes to those files.
Once we do a release and these files are merged to the copy in feedstock, we should remove these 2 files from the project repo.

@muryanto1 muryanto1 requested review from downiec and jasonb5 May 1, 2020 19:31
Copy link
Contributor

@downiec downiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but I'm wondering what the commented out code is for. Do you think the commented out code might be needed in future?

@muryanto1
Copy link
Member Author

@downiec I removed commented out code. Thanks.

@muryanto1 muryanto1 merged commit 74a3a99 into master May 1, 2020
@muryanto1 muryanto1 deleted the feedstock_recipe branch May 4, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants