fix: deleting profile will refresh current profile storage and tasks #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After deletionprofile, tasks and storage directory was not being synced. Fixes: CCExtractor#423
1 task
|
@SGI-CAPP-AT2 Some test cases failed. Can you check once? |
Yep, those test cases are not about this PR. and those are already fixed by #427. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After deletionprofile, tasks and storage directory was not being synced. Fixes: #423
This has been fixed by adding
Get.find<HomeController>().refreshTaskWithNewProfile();which syncs tasks and directory for current profile storage as suggested by @BrawlerXullFixes #423
Replace
issue_nowith the issue number which is fixed in this PRScreenshots
bug_fix_del.mp4
Checklist