Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add log module in lib_ccxr #1622

Merged
merged 12 commits into from
Jul 16, 2024

Conversation

IshanGrover2004
Copy link
Contributor

@IshanGrover2004 IshanGrover2004 commented Jul 6, 2024

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Closes #1553

This PR adds functions and macros used for logging operations. The functions of this PR have not been integrated into the C codebase since there is no safe or easy way to pass variable number of arguments (as used in printf) from C to Rust. But the code for initializing the logger from C to Rust is included.

After this PR merge, anybody can use macros like info!, fata!, error!, debug! (Just like mprint, fatal, etc in C) for logging purposes after initializing logger using ccxr_init_basic_logger

@IshanGrover2004
Copy link
Contributor Author

@PunitLodha The PR is ready, you can review it

@ccextractor-bot

This comment was marked as off-topic.

@elbertronnie
Copy link
Contributor

Just got to know about this due to the closing of #1551. @IshanGrover2004 If you have any doubts regarding the code written by me, you can ask in Github or Slack. I can probably help as an external reviewer.

@IshanGrover2004
Copy link
Contributor Author

Sure @elbertronnie
Thank you 😊 btw

src/rust/lib_ccxr/src/util/log.rs Outdated Show resolved Hide resolved
src/rust/lib_ccxr/src/util/log.rs Outdated Show resolved Hide resolved
src/rust/lib_ccxr/src/util/log.rs Outdated Show resolved Hide resolved
src/rust/lib_ccxr/src/util/log.rs Outdated Show resolved Hide resolved
src/rust/lib_ccxr/src/util/log.rs Outdated Show resolved Hide resolved
@IshanGrover2004
Copy link
Contributor Author

@PunitLodha Did the changes

@ccextractor-bot

This comment was marked as outdated.

@PunitLodha PunitLodha merged commit f5da158 into CCExtractor:master Jul 16, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants