-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Add log module in lib_ccxr #1622
Merged
PunitLodha
merged 12 commits into
CCExtractor:master
from
IshanGrover2004:migration-log-module
Jul 16, 2024
Merged
[FEAT] Add log module in lib_ccxr #1622
PunitLodha
merged 12 commits into
CCExtractor:master
from
IshanGrover2004:migration-log-module
Jul 16, 2024
+655
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@PunitLodha The PR is ready, you can review it |
This comment was marked as off-topic.
This comment was marked as off-topic.
Just got to know about this due to the closing of #1551. @IshanGrover2004 If you have any doubts regarding the code written by me, you can ask in Github or Slack. I can probably help as an external reviewer. |
Sure @elbertronnie |
elbertronnie
suggested changes
Jul 7, 2024
PunitLodha
requested changes
Jul 9, 2024
@PunitLodha Did the changes |
elbertronnie
reviewed
Jul 9, 2024
This comment was marked as outdated.
This comment was marked as outdated.
PunitLodha
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Closes #1553
This PR adds functions and macros used for logging operations. The functions of this PR have not been integrated into the C codebase since there is no safe or easy way to pass variable number of arguments (as used in printf) from C to Rust. But the code for initializing the logger from C to Rust is included.
After this PR merge, anybody can use macros like
info!
,fata!
,error!
,debug!
(Just likemprint
,fatal
, etc in C) for logging purposes after initializing logger usingccxr_init_basic_logger