-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Unexpected behavior of get_write_interval #1609
[FIX] Unexpected behavior of get_write_interval #1609
Conversation
Adresses Issue#1606
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm just wondering why the CI is failing 🤔
Please wait for @cfsmp3's review.
Yeah mac CI fails for the hardsubx part which is not even touched |
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit f08febf...:
All tests passing on the master branch were passed completely. NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
Check the result page for more info. |
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Closes #1606
Issue addresed
This pull request addresses issue #1606 where the get_write_interval function incorrectly returns (0,209) for a packet does not contain captions, implying that caption packets are available from index 0 to 209 which needs to be corrected.
Correction Made
The correction ensures that the correct interval (0,0) is returned, indicating that there are no captions available to write.
Implementation Details
By initialising
last
variable which stores last caption available by 0