[FEATURE] Port 708 decoder encoding module to RUST #1607

IshanGrover2004 · 2024-04-19T12:49:13Z

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

I have migrated the logic and functions from the lib_ccx/ccx_decoder_708_encoding.c file to Rust, located in decoder/encoding.rs. This conversion maintains the same functionality that was originally written in C, now implemented in Rust.

To know more See ccx_decoder_708_encoding.c and compare with File Changed in PR, they are both same

Background & Testing

Current codebase scenerio: Only C code of ccx_decoder_708_encoding.c file is available. So while making & running Rust test cases which requires these functions do not have body because cargo test is just seeing the rust code only.
After PR changes: Exact same logic of rust code will be there. And I did also added the conditional compilation so that if user build with -without-rust then only C code will work or else Rust code will build. And Yes I have manually tested that when compiling with rust src files, rust code is being used and giving the same result.

This `decoder/encoding.rs` file will contain the content of `lib_ccx/ccx_708_decoder_encoding.c` file

…odule

thealphadollar

LGTM, thanks for the contribution.

Please wait for review from @cfsmp3

ccextractor-bot · 2024-05-16T04:47:35Z

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 2ada36d...:

Report Name	Tests Passed
Broken	13/13
CEA-708	14/14
DVB	4/7
DVD	3/3
DVR-MS	2/2
General	24/27
Hauppage	3/3
MP4	3/3
NoCC	10/10
Options	85/86
Teletext	21/21
WTV	13/13
XDS	34/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

ccextractor --autoprogram --out=srt --latin1 85271be4d2..., Last passed: Never
ccextractor --stdout --quiet --no-fontcolor 79a51f3500..., Last passed: Never
ccextractor --stdout --quiet --no-fontcolor 767b546f96..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 1974a299f0..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 132d7df7e9..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 99e5eaafdc..., Last passed: Never
ccextractor --capfile /repository/Dictionary/MattS_dictionary.txt c83f765c66..., Last passed: Never

Congratulations: Merging this PR would fix the following tests:

ccextractor --autoprogram --out=srt --latin1 1d9731bd80..., Last passed: Test 4898
ccextractor --out=sami --latin1 --autoprogram 5b4e0a6034..., Last passed: Test 4898
ccextractor --out=srt --latin1 --autoprogram 73d9313d64..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 8e8229b88b..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 7236304cfc..., Last passed: Test 4898
ccextractor --out=ttxt --latin1 001dd8cdf7..., Last passed: Test 4898
ccextractor --out=srt --latin1 06b3a9237d..., Last passed: Test 4898
ccextractor --out=srt --latin1 83f8cceb74..., Last passed: Test 4898
ccextractor --out=srt --latin1 611b4a9235..., Last passed: Test 4898
ccextractor --out=srt --latin1 b46e9e8e3f..., Last passed: Test 4898
ccextractor --out=srt --latin1 89e417e622..., Last passed: Test 4898
ccextractor --out=srt --latin1 d59eadc4ed..., Last passed: Test 4898
ccextractor --out=srt --latin1 4d4e938ef6..., Last passed: Test 4898
ccextractor --service 1 --out=txt --no-bom --no-rollup ea83ff7bcb..., Last passed: Test 4898
ccextractor --service 1 --out=txt f17524b53f..., Last passed: Test 4898
ccextractor --service 1 --out=txt da904de35d..., Last passed: Test 4898
ccextractor --service 1 --out=txt 80848c45f8..., Last passed: Test 4898
ccextractor --service 1 --out=txt --no-bom --no-rollup b5d6aad89f..., Last passed: Test 4898
ccextractor --service 1[EUC-KR] --out=txt --no-rollup b5d6aad89f..., Last passed: Test 4898
ccextractor --service 1 --out=srt da904de35d..., Last passed: Test 4898
ccextractor --service 1 --out=sami da904de35d..., Last passed: Test 4898
ccextractor --service 1 --out=ttxt da904de35d..., Last passed: Test 4898
ccextractor --service 1[EUC-KR] b5d6aad89f..., Last passed: Test 4898
ccextractor --service 1[EUC-KR] --no-rollup b5d6aad89f..., Last passed: Test 4898
ccextractor --service all da904de35d..., Last passed: Test 4898
ccextractor --service all[EUC-KR] b5d6aad89f..., Last passed: Test 4898
ccextractor --service 1,2[UTF-8],3[EUC-KR],54 --out=txt da904de35d..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 1020459a86..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 f1422b8bfe..., Last passed: Test 4898
ccextractor --datapid 5603 --autoprogram --out=srt --latin1 --teletext 85c7fc1ad7..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 d41b53b504..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 5ae2007a79..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 1e44efd810..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 add511677c..., Last passed: Test 4898
ccextractor --wtvconvertfix --autoprogram --out=srt --latin1 acf871cbfd..., Last passed: Test 4898
ccextractor --wtvconvertfix --autoprogram --out=srt --latin1 5cbb21adb6..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 9a496d3828..., Last passed: Test 4898
ccextractor --out=srt --latin1 --autoprogram 56c9f34548..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 e9b9008fdf..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 c032183ef0..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 27e46255f0..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 d037c7509e..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 b22260d065..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla 7aad20907e..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla c41f73056a..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla 5d3a29f9f8..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla 70000200c0..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla 6dc772d881..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla dab1c1bd65..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla adce82fd39..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla 15feae9133..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla 95dd33c6f1..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 01509e4d27..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla ab9cf8cfad..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 15feae9133..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla --output-field 2 5d3a29f9f8..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla --output-field 2 c41f73056a..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 --sentencecap c032183ef0..., Last passed: Test 4898
ccextractor --autoprogram --out=bin --latin1 c032183ef0..., Last passed: Test 4898
ccextractor --out=srt --latin1 --autoprogram 29e5ffd34b..., Last passed: Test 4898
ccextractor --hauppauge --autoprogram --out=srt --latin1 a03b5b2a56..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --hauppauge --latin1 553d78e755..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --hauppauge --ucla --latin1 553d78e755..., Last passed: Test 4898
ccextractor --in=mp4 --out=srt --latin1 b2771c84c2..., Last passed: Test 4898
ccextractor --in=mp4 --out=srt --latin1 5df914ce77..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --bom --latin1 8849331dda..., Last passed: Test 4898
ccextractor --mp4vidtrack --autoprogram --out=ttxt --latin1 adc0a818c3..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 08bdf0e2c1..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 bee139671a..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 3842d00925..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 80af83c038..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 837b02f722..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 41dab6b2a7..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 4b117b4d66..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 26ee6add4d..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds fca0dce412..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 --output-field 1 a65d39ccb3..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 --output-field 2 a65d39ccb3..., Last passed: Test 4898
ccextractor --autoprogram c83f765c66..., Last passed: Test 4898
ccextractor --service 1 c83f765c66..., Last passed: Test 4898
ccextractor --in=ts c83f765c66..., Last passed: Test 4898
ccextractor --out=srt c83f765c66..., Last passed: Test 4898
ccextractor --out=sami c83f765c66..., Last passed: Test 4898
ccextractor --out=dvdraw c83f765c66..., Last passed: Test 4898
ccextractor --out=txt c83f765c66..., Last passed: Test 4898
ccextractor --out=ttxt c83f765c66..., Last passed: Test 4898
ccextractor --out=smptett c83f765c66..., Last passed: Test 4898
ccextractor --out=spupng c83f765c66..., Last passed: Test 4855
ccextractor --goptime c83f765c66..., Last passed: Test 4898
ccextractor --no-goptime c83f765c66..., Last passed: Test 4898
ccextractor --fixpadding c83f765c66..., Last passed: Test 4898
ccextractor --90090 c83f765c66..., Last passed: Test 4898
ccextractor --myth c83f765c66..., Last passed: Test 4898
ccextractor --program-number 1 c83f765c66..., Last passed: Test 4898
ccextractor --datapid 256 c83f765c66..., Last passed: Test 4898
ccextractor --datastreamtype 2 c83f765c66..., Last passed: Test 4898
ccextractor --datastreamtype 2 --streamtype 2 c83f765c66..., Last passed: Test 4898
ccextractor --no-autotimeref c83f765c66..., Last passed: Test 4898
ccextractor --bom c83f765c66..., Last passed: Test 4898
ccextractor --no-bom c83f765c66..., Last passed: Test 4898
ccextractor --unicode c83f765c66..., Last passed: Test 4898
ccextractor --utf8 c83f765c66..., Last passed: Test 4898
ccextractor --latin1 c83f765c66..., Last passed: Test 4898
ccextractor --no-fontcolor c83f765c66..., Last passed: Test 4898
ccextractor --no-typesetting c83f765c66..., Last passed: Test 4898
ccextractor --trim c83f765c66..., Last passed: Test 4898
ccextractor --sentencecap c83f765c66..., Last passed: Test 4898
ccextractor --unixts 5 --out=txt c83f765c66..., Last passed: Test 4898
ccextractor --out=txt --datets c83f765c66..., Last passed: Test 4898
ccextractor --out=txt --sects c83f765c66..., Last passed: Test 4898
ccextractor --out=txt --UCLA c83f765c66..., Last passed: Test 4898
ccextractor --out=txt --lf c83f765c66..., Last passed: Test 4898
ccextractor --autodash --trim c83f765c66..., Last passed: Test 4898
ccextractor --bufferinput c83f765c66..., Last passed: Test 4898
ccextractor --no-bufferinput c83f765c66..., Last passed: Test 4898
ccextractor --buffersize 1M c83f765c66..., Last passed: Test 4898
ccextractor --dru c83f765c66..., Last passed: Test 4898
ccextractor --no-rollup c83f765c66..., Last passed: Test 4898
ccextractor --ru1 c83f765c66..., Last passed: Test 4898
ccextractor --ru2 c83f765c66..., Last passed: Test 4898
ccextractor --ru3 c83f765c66..., Last passed: Test 4898
ccextractor --delay 200 c83f765c66..., Last passed: Test 4898
ccextractor --startat 4 --endat 7 c83f765c66..., Last passed: Test 4898
ccextractor --no-codec dvbsub c83f765c66..., Last passed: Test 4898
ccextractor --debug --out=srt c83f765c66..., Last passed: Test 4898
ccextractor --608 --out=srt c83f765c66..., Last passed: Test 4898
ccextractor --708 --out=srt c83f765c66..., Last passed: Test 4898
ccextractor --goppts --out=srt c83f765c66..., Last passed: Test 4898
ccextractor --xdsdebug --out=srt c83f765c66..., Last passed: Test 4898
ccextractor --vides --out=srt c83f765c66..., Last passed: Test 4898
ccextractor --cbraw --out=srt c83f765c66..., Last passed: Test 4898
ccextractor --no-sync --out=srt c83f765c66..., Last passed: Test 4898
ccextractor --fullbin --out=srt c83f765c66..., Last passed: Test 4898
ccextractor --parsedebug --out=srt c83f765c66..., Last passed: Test 4898
ccextractor --parsePAT --out=srt c83f765c66..., Last passed: Test 4898
ccextractor --parsePMT --out=srt c83f765c66..., Last passed: Test 4898
ccextractor --investigate-packets --out=srt c83f765c66..., Last passed: Test 4898
ccextractor --in=ps e9b9008fdf..., Last passed: Test 4898
ccextractor --in=es dc7169d7c4..., Last passed: Test 4898
ccextractor --in=asf 6395b281ad..., Last passed: Test 4898
ccextractor --in=wtv b46e9e8e3f..., Last passed: Test 4898
ccextractor --in=bin 988d4e8bba..., Last passed: Test 4898
ccextractor --in=raw fb79021542..., Last passed: Test 4898
ccextractor --in=mp4 b2771c84c2..., Last passed: Test 4898
ccextractor --mp4vidtrack 5df914ce77..., Last passed: Test 4898
ccextractor --wtvconvertfix acf871cbfd..., Last passed: Test 4898
ccextractor --wtvmpeg2 10f0f77cf4..., Last passed: Test 4898
ccextractor --hauppauge d6df1b227a..., Last passed: Test 4898
ccextractor --xmltv --out=null 96efd279cf..., Last passed: Test 4898
ccextractor --codec dvbsub --out=spupng 85271be4d2..., Last passed: Test 4898
ccextractor --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 4898
ccextractor --startcreditsnotbefore 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 4898
ccextractor --startcreditsnotafter 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 4898
ccextractor --startcreditsforatleast 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 4898
ccextractor --startcreditsforatmost 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 4898
ccextractor --endcreditstext "CCextractor Ends crdit Testing" addf5e2fc9..., Last passed: Test 4898
ccextractor --endcreditsforatleast 3 --endcreditstext "CCextractor Ends crdit Testing" addf5e2fc9..., Last passed: Test 4898
ccextractor --endcreditsforatmost 2 --endcreditstext "CCextractor Ends crdit Testing" addf5e2fc9..., Last passed: Test 4898
ccextractor --tpage 801 4e56e88ba4..., Last passed: Test 4898
ccextractor --tverbose 4e56e88ba4..., Last passed: Test 4898
ccextractor --teletext 4e56e88ba4..., Last passed: Test 4898
ccextractor --datapid 2310 --autoprogram --out=srt --latin1 e639e54550..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 4e56e88ba4..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 c0d2fba8c0..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 006fdc391a..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 e92a1d4d2a..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 b37ce60eb9..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 7e4ebf7fd7..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 9256a60e4b..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 27d7a43dd6..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 297a44921a..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 efbe129086..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 eae0077731..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 e2e2b501e0..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 8c1615c1a8..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 c6407fb294..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --datets dcada745de..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 --tpage 398 5d5838bde9..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 --tpage 299 44c45593fb..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 --tpage 299 b8c55aa2e9..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 --teletext --tpage 398 3b276ad8bf..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 b236a0590b..., Last passed: Test 4898
ccextractor --out=srt --latin1 f23a544ba8..., Last passed: Test 4881
ccextractor --out=srt --latin1 97cc394d87..., Last passed: Test 4880
ccextractor --out=srt --latin1 10f0f77cf4..., Last passed: Test 4881
ccextractor --out=srt --latin1 df3b4d62d3..., Last passed: Test 4881
ccextractor --out=srt --latin1 d7e7dbdf68..., Last passed: Test 4898
ccextractor --out=srt --latin1 76734ac4a7..., Last passed: Test 4898
ccextractor --out=srt --latin1 c791382c94..., Last passed: Test 4898
ccextractor --out=srt --latin1 f673b2f916..., Last passed: Test 4898
ccextractor --out=srt --latin1 da75bdee47..., Last passed: Test 4898
ccextractor --out=srt --latin1 bd6f33a669..., Last passed: Test 4898
ccextractor --out=srt --latin1 0e5e6b26be..., Last passed: Test 4898
ccextractor --out=srt --latin1 a226cc302d..., Last passed: Test 4898
ccextractor --out=srt --latin1 ae6327683e..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 725a49f871..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla d037c7509e..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 --ucla d037c7509e..., Last passed: Test 4898
ccextractor --autoprogram --out=smptett --latin1 --ucla e274a73653..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla e274a73653..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla 85058ad37e..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds b22260d065..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 --ucla b22260d065..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --xds --ucla c813e713a0..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 --ucla c813e713a0..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 27fab4dbb6..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 --ucla 27fab4dbb6..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds bbd5bb52fc..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 --ucla bbd5bb52fc..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds b992e0cccb..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds d0291cdcf6..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla 7d2730d38e..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 --ucla 7d2730d38e..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds c8dc039a88..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 --ucla c8dc039a88..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 53339f3455..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 --ucla 53339f3455..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 83b03036a2..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 --ucla 83b03036a2..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 7d3f25c32c..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 --ucla 7d3f25c32c..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds f41d4c29a1..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 --ucla f41d4c29a1..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 88cd42b89a..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 --ucla 88cd42b89a..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 --output-field 2 --ucla 88cd42b89a..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 7f41299cc7..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 --ucla 7f41299cc7..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 0069dffd21..., Last passed: Test 4898

Check the result page for more info.

PunitLodha

Are the rust extern functions automatically picked up by C because they have the same name? I remember having to define extern fn ... in C and then having to call it like this,

#ifndef DISABLE_RUST
	// Use rust function here
#else
	// Use C function here
#endif

Is that not needed?

src/rust/src/decoder/encoding.rs

PunitLodha · 2024-05-22T13:10:44Z

@prateekmedia Any idea why Windows is failing here?

IshanGrover2004 · 2024-05-26T08:41:43Z

@PunitLodha You can go on for merge if you find correct, btw this method of having same name is working, I have checked it

And another thing I have also Enable the default_feature of bindgen bcs this becomes useful while developing in Rust & also used in next PRs as well

ccextractor-bot · 2024-05-26T10:17:37Z

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 5748042...:

Report Name	Tests Passed
Broken	13/13
CEA-708	14/14
DVB	4/7
DVD	3/3
DVR-MS	2/2
General	24/27
Hauppage	3/3
MP4	3/3
NoCC	10/10
Options	84/86
Teletext	21/21
WTV	9/13
XDS	34/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

ccextractor --autoprogram --out=srt --latin1 85271be4d2..., Last passed: Never
ccextractor --stdout --quiet --no-fontcolor 79a51f3500..., Last passed: Never
ccextractor --stdout --quiet --no-fontcolor 767b546f96..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 1974a299f0..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 132d7df7e9..., Last passed: Never
ccextractor --autoprogram --out=ttxt --latin1 99e5eaafdc..., Last passed: Never
ccextractor --out=spupng c83f765c66..., Last passed: Test 4855
ccextractor --capfile /repository/Dictionary/MattS_dictionary.txt c83f765c66..., Last passed: Never
ccextractor --out=srt --latin1 f23a544ba8..., Last passed: Test 4881
ccextractor --out=srt --latin1 97cc394d87..., Last passed: Test 4880
ccextractor --out=srt --latin1 10f0f77cf4..., Last passed: Test 4881
ccextractor --out=srt --latin1 df3b4d62d3..., Last passed: Test 4881

Congratulations: Merging this PR would fix the following tests:

ccextractor --autoprogram --out=srt --latin1 1d9731bd80..., Last passed: Test 4970
ccextractor --out=sami --latin1 --autoprogram 5b4e0a6034..., Last passed: Test 4898
ccextractor --out=srt --latin1 --autoprogram 73d9313d64..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 8e8229b88b..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 7236304cfc..., Last passed: Test 4970
ccextractor --out=ttxt --latin1 001dd8cdf7..., Last passed: Test 4970
ccextractor --out=srt --latin1 06b3a9237d..., Last passed: Test 4970
ccextractor --out=srt --latin1 83f8cceb74..., Last passed: Test 4970
ccextractor --out=srt --latin1 611b4a9235..., Last passed: Test 4970
ccextractor --out=srt --latin1 b46e9e8e3f..., Last passed: Test 4970
ccextractor --out=srt --latin1 89e417e622..., Last passed: Test 4970
ccextractor --out=srt --latin1 d59eadc4ed..., Last passed: Test 4970
ccextractor --out=srt --latin1 4d4e938ef6..., Last passed: Test 4970
ccextractor --service 1 --out=txt --no-bom --no-rollup ea83ff7bcb..., Last passed: Test 4970
ccextractor --service 1 --out=txt f17524b53f..., Last passed: Test 4970
ccextractor --service 1 --out=txt da904de35d..., Last passed: Test 4970
ccextractor --service 1 --out=txt 80848c45f8..., Last passed: Test 4970
ccextractor --service 1 --out=txt --no-bom --no-rollup b5d6aad89f..., Last passed: Test 4970
ccextractor --service 1[EUC-KR] --out=txt --no-rollup b5d6aad89f..., Last passed: Test 4970
ccextractor --service 1 --out=srt da904de35d..., Last passed: Test 4970
ccextractor --service 1 --out=sami da904de35d..., Last passed: Test 4970
ccextractor --service 1 --out=ttxt da904de35d..., Last passed: Test 4970
ccextractor --service 1[EUC-KR] b5d6aad89f..., Last passed: Test 4970
ccextractor --service 1[EUC-KR] --no-rollup b5d6aad89f..., Last passed: Test 4970
ccextractor --service all da904de35d..., Last passed: Test 4970
ccextractor --service all[EUC-KR] b5d6aad89f..., Last passed: Test 4970
ccextractor --service 1,2[UTF-8],3[EUC-KR],54 --out=txt da904de35d..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 1020459a86..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --latin1 f1422b8bfe..., Last passed: Test 4970
ccextractor --datapid 5603 --autoprogram --out=srt --latin1 --teletext 85c7fc1ad7..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --latin1 d41b53b504..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 5ae2007a79..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 1e44efd810..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 add511677c..., Last passed: Test 4970
ccextractor --wtvconvertfix --autoprogram --out=srt --latin1 acf871cbfd..., Last passed: Test 4970
ccextractor --wtvconvertfix --autoprogram --out=srt --latin1 5cbb21adb6..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 9a496d3828..., Last passed: Test 4970
ccextractor --out=srt --latin1 --autoprogram 56c9f34548..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --latin1 e9b9008fdf..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 c032183ef0..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 27e46255f0..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 d037c7509e..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --latin1 b22260d065..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla 7aad20907e..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla c41f73056a..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla 5d3a29f9f8..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla 70000200c0..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 --ucla 6dc772d881..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 --ucla dab1c1bd65..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 --ucla adce82fd39..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 --ucla 15feae9133..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla 95dd33c6f1..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 01509e4d27..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla ab9cf8cfad..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --latin1 15feae9133..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla --output-field 2 5d3a29f9f8..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 --ucla --output-field 2 c41f73056a..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --latin1 --sentencecap c032183ef0..., Last passed: Test 4970
ccextractor --autoprogram --out=bin --latin1 c032183ef0..., Last passed: Test 4970
ccextractor --out=srt --latin1 --autoprogram 29e5ffd34b..., Last passed: Test 4970
ccextractor --hauppauge --autoprogram --out=srt --latin1 a03b5b2a56..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --hauppauge --latin1 553d78e755..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --hauppauge --ucla --latin1 553d78e755..., Last passed: Test 4898
ccextractor --in=mp4 --out=srt --latin1 b2771c84c2..., Last passed: Test 4970
ccextractor --in=mp4 --out=srt --latin1 5df914ce77..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --bom --latin1 8849331dda..., Last passed: Test 4898
ccextractor --mp4vidtrack --autoprogram --out=ttxt --latin1 adc0a818c3..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 08bdf0e2c1..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 bee139671a..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 3842d00925..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 80af83c038..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 837b02f722..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --latin1 41dab6b2a7..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 4b117b4d66..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 26ee6add4d..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds fca0dce412..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --latin1 --output-field 1 a65d39ccb3..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 --output-field 2 a65d39ccb3..., Last passed: Test 4970
ccextractor --autoprogram c83f765c66..., Last passed: Test 4970
ccextractor --service 1 c83f765c66..., Last passed: Test 4970
ccextractor --in=ts c83f765c66..., Last passed: Test 4970
ccextractor --out=srt c83f765c66..., Last passed: Test 4970
ccextractor --out=sami c83f765c66..., Last passed: Test 4970
ccextractor --out=dvdraw c83f765c66..., Last passed: Test 4970
ccextractor --out=txt c83f765c66..., Last passed: Test 4970
ccextractor --out=ttxt c83f765c66..., Last passed: Test 4970
ccextractor --out=smptett c83f765c66..., Last passed: Test 4970
ccextractor --goptime c83f765c66..., Last passed: Test 4970
ccextractor --no-goptime c83f765c66..., Last passed: Test 4970
ccextractor --fixpadding c83f765c66..., Last passed: Test 4970
ccextractor --90090 c83f765c66..., Last passed: Test 4970
ccextractor --myth c83f765c66..., Last passed: Test 4970
ccextractor --program-number 1 c83f765c66..., Last passed: Test 4970
ccextractor --datapid 256 c83f765c66..., Last passed: Test 4970
ccextractor --datastreamtype 2 c83f765c66..., Last passed: Test 4970
ccextractor --datastreamtype 2 --streamtype 2 c83f765c66..., Last passed: Test 4970
ccextractor --no-autotimeref c83f765c66..., Last passed: Test 4970
ccextractor --bom c83f765c66..., Last passed: Test 4970
ccextractor --no-bom c83f765c66..., Last passed: Test 4970
ccextractor --unicode c83f765c66..., Last passed: Test 4970
ccextractor --utf8 c83f765c66..., Last passed: Test 4898
ccextractor --latin1 c83f765c66..., Last passed: Test 4970
ccextractor --no-fontcolor c83f765c66..., Last passed: Test 4970
ccextractor --no-typesetting c83f765c66..., Last passed: Test 4970
ccextractor --trim c83f765c66..., Last passed: Test 4970
ccextractor --sentencecap c83f765c66..., Last passed: Test 4970
ccextractor --unixts 5 --out=txt c83f765c66..., Last passed: Test 4970
ccextractor --out=txt --datets c83f765c66..., Last passed: Test 4970
ccextractor --out=txt --sects c83f765c66..., Last passed: Test 4970
ccextractor --out=txt --UCLA c83f765c66..., Last passed: Test 4970
ccextractor --out=txt --lf c83f765c66..., Last passed: Test 4970
ccextractor --autodash --trim c83f765c66..., Last passed: Test 4970
ccextractor --bufferinput c83f765c66..., Last passed: Test 4970
ccextractor --no-bufferinput c83f765c66..., Last passed: Test 4970
ccextractor --buffersize 1M c83f765c66..., Last passed: Test 4970
ccextractor --dru c83f765c66..., Last passed: Test 4970
ccextractor --no-rollup c83f765c66..., Last passed: Test 4970
ccextractor --ru1 c83f765c66..., Last passed: Test 4970
ccextractor --ru2 c83f765c66..., Last passed: Test 4970
ccextractor --ru3 c83f765c66..., Last passed: Test 4970
ccextractor --delay 200 c83f765c66..., Last passed: Test 4970
ccextractor --startat 4 --endat 7 c83f765c66..., Last passed: Test 4970
ccextractor --no-codec dvbsub c83f765c66..., Last passed: Test 4970
ccextractor --debug --out=srt c83f765c66..., Last passed: Test 4970
ccextractor --608 --out=srt c83f765c66..., Last passed: Test 4970
ccextractor --708 --out=srt c83f765c66..., Last passed: Test 4970
ccextractor --goppts --out=srt c83f765c66..., Last passed: Test 4970
ccextractor --xdsdebug --out=srt c83f765c66..., Last passed: Test 4970
ccextractor --vides --out=srt c83f765c66..., Last passed: Test 4970
ccextractor --cbraw --out=srt c83f765c66..., Last passed: Test 4970
ccextractor --no-sync --out=srt c83f765c66..., Last passed: Test 4970
ccextractor --fullbin --out=srt c83f765c66..., Last passed: Test 4970
ccextractor --parsedebug --out=srt c83f765c66..., Last passed: Test 4970
ccextractor --parsePAT --out=srt c83f765c66..., Last passed: Test 4970
ccextractor --parsePMT --out=srt c83f765c66..., Last passed: Test 4970
ccextractor --investigate-packets --out=srt c83f765c66..., Last passed: Test 4970
ccextractor --in=ps e9b9008fdf..., Last passed: Test 4970
ccextractor --in=es dc7169d7c4..., Last passed: Test 4898
ccextractor --in=asf 6395b281ad..., Last passed: Test 4970
ccextractor --in=wtv b46e9e8e3f..., Last passed: Test 4970
ccextractor --in=bin 988d4e8bba..., Last passed: Test 4970
ccextractor --in=raw fb79021542..., Last passed: Test 4970
ccextractor --in=mp4 b2771c84c2..., Last passed: Test 4970
ccextractor --mp4vidtrack 5df914ce77..., Last passed: Test 4970
ccextractor --wtvconvertfix acf871cbfd..., Last passed: Test 4970
ccextractor --wtvmpeg2 10f0f77cf4..., Last passed: Test 4970
ccextractor --hauppauge d6df1b227a..., Last passed: Test 4970
ccextractor --xmltv --out=null 96efd279cf..., Last passed: Test 4970
ccextractor --codec dvbsub --out=spupng 85271be4d2..., Last passed: Test 4970
ccextractor --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 4970
ccextractor --startcreditsnotbefore 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 4970
ccextractor --startcreditsnotafter 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 4970
ccextractor --startcreditsforatleast 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 4970
ccextractor --startcreditsforatmost 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 4970
ccextractor --endcreditstext "CCextractor Ends crdit Testing" addf5e2fc9..., Last passed: Test 4970
ccextractor --endcreditsforatleast 3 --endcreditstext "CCextractor Ends crdit Testing" addf5e2fc9..., Last passed: Test 4970
ccextractor --endcreditsforatmost 2 --endcreditstext "CCextractor Ends crdit Testing" addf5e2fc9..., Last passed: Test 4970
ccextractor --tpage 801 4e56e88ba4..., Last passed: Test 4970
ccextractor --tverbose 4e56e88ba4..., Last passed: Test 4970
ccextractor --teletext 4e56e88ba4..., Last passed: Test 4970
ccextractor --datapid 2310 --autoprogram --out=srt --latin1 e639e54550..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --latin1 4e56e88ba4..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 c0d2fba8c0..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 006fdc391a..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 e92a1d4d2a..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 b37ce60eb9..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 7e4ebf7fd7..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 9256a60e4b..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 27d7a43dd6..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 297a44921a..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 efbe129086..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 eae0077731..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 e2e2b501e0..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 8c1615c1a8..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 c6407fb294..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 --datets dcada745de..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --latin1 --tpage 398 5d5838bde9..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --latin1 --tpage 299 44c45593fb..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --latin1 --tpage 299 b8c55aa2e9..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --latin1 --teletext --tpage 398 3b276ad8bf..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 b236a0590b..., Last passed: Test 4970
ccextractor --out=srt --latin1 d7e7dbdf68..., Last passed: Test 4898
ccextractor --out=srt --latin1 76734ac4a7..., Last passed: Test 4898
ccextractor --out=srt --latin1 c791382c94..., Last passed: Test 4898
ccextractor --out=srt --latin1 f673b2f916..., Last passed: Test 4898
ccextractor --out=srt --latin1 da75bdee47..., Last passed: Test 4898
ccextractor --out=srt --latin1 bd6f33a669..., Last passed: Test 4898
ccextractor --out=srt --latin1 0e5e6b26be..., Last passed: Test 4898
ccextractor --out=srt --latin1 a226cc302d..., Last passed: Test 4898
ccextractor --out=srt --latin1 ae6327683e..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 725a49f871..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla d037c7509e..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --latin1 --ucla d037c7509e..., Last passed: Test 4970
ccextractor --autoprogram --out=smptett --latin1 --ucla e274a73653..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla e274a73653..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla 85058ad37e..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds b22260d065..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --latin1 --ucla b22260d065..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --xds --ucla c813e713a0..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 --ucla c813e713a0..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 27fab4dbb6..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --latin1 --ucla 27fab4dbb6..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds bbd5bb52fc..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --latin1 --ucla bbd5bb52fc..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds b992e0cccb..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds d0291cdcf6..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 --ucla 7d2730d38e..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --latin1 --ucla 7d2730d38e..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds c8dc039a88..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --latin1 --ucla c8dc039a88..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 53339f3455..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --latin1 --ucla 53339f3455..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 83b03036a2..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --latin1 --ucla 83b03036a2..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 7d3f25c32c..., Last passed: Test 4898
ccextractor --autoprogram --out=srt --latin1 --ucla 7d3f25c32c..., Last passed: Test 4898
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds f41d4c29a1..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --latin1 --ucla f41d4c29a1..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 88cd42b89a..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --latin1 --ucla 88cd42b89a..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --latin1 --output-field 2 --ucla 88cd42b89a..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 7f41299cc7..., Last passed: Test 4970
ccextractor --autoprogram --out=srt --latin1 --ucla 7f41299cc7..., Last passed: Test 4970
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 0069dffd21..., Last passed: Test 4970

Check the result page for more info.

* feat: Add `decoder/encoding` new module This `decoder/encoding.rs` file will contain the content of `lib_ccx/ccx_708_decoder_encoding.c` file * feat: Add encoding functions * feat: Add conditional compilation to include Rust functions * fix: conditional compilation logic * refactor: Use of match statement instead of if-else * fix: Calling C function for rust * feat: Enable `derive_default` feature

IshanGrover2004 and others added 5 commits April 19, 2024 18:10

feat: Add decoder/encoding new module

0e0a001

This `decoder/encoding.rs` file will contain the content of `lib_ccx/ccx_708_decoder_encoding.c` file

feat: Add encoding functions

fc39970

feat: Add conditional compilation to include Rust functions

0d42f3e

Merge branch 'CCExtractor:master' into feature/708-decoder-encoding-m…

b89cde1

…odule

fix: conditional compilation logic

37c74f2

thealphadollar approved these changes May 14, 2024

View reviewed changes

prateekmedia requested a review from PunitLodha May 19, 2024 11:27

PunitLodha reviewed May 20, 2024

View reviewed changes

src/rust/src/decoder/encoding.rs Outdated Show resolved Hide resolved

IshanGrover2004 added 2 commits May 21, 2024 14:09

refactor: Use of match statement instead of if-else

b8a7fd6

fix: Calling C function for rust

031ac7d

feat: Enable derive_default feature

d79087e

PunitLodha approved these changes May 29, 2024

View reviewed changes

PunitLodha merged commit d6ccf1b into CCExtractor:master May 29, 2024
12 of 17 checks passed

IshanGrover2004 deleted the feature/708-decoder-encoding-module branch May 29, 2024 08:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEATURE] Port 708 decoder encoding module to RUST #1607

[FEATURE] Port 708 decoder encoding module to RUST #1607

IshanGrover2004 commented Apr 19, 2024 •

edited

Loading

thealphadollar left a comment •

edited

Loading

ccextractor-bot commented May 16, 2024

PunitLodha left a comment

PunitLodha commented May 22, 2024

IshanGrover2004 commented May 26, 2024 •

edited

Loading

ccextractor-bot commented May 26, 2024

[FEATURE] Port 708 decoder encoding module to RUST #1607

[FEATURE] Port 708 decoder encoding module to RUST #1607

Conversation

IshanGrover2004 commented Apr 19, 2024 • edited Loading

Background & Testing

thealphadollar left a comment • edited Loading

Choose a reason for hiding this comment

ccextractor-bot commented May 16, 2024

PunitLodha left a comment

Choose a reason for hiding this comment

PunitLodha commented May 22, 2024

IshanGrover2004 commented May 26, 2024 • edited Loading

ccextractor-bot commented May 26, 2024

IshanGrover2004 commented Apr 19, 2024 •

edited

Loading

thealphadollar left a comment •

edited

Loading

IshanGrover2004 commented May 26, 2024 •

edited

Loading