Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rsmpeg to latest version for ffmpeg bindings #1600

Merged
merged 2 commits into from
Mar 3, 2024

Conversation

IshanGrover2004
Copy link
Contributor

@IshanGrover2004 IshanGrover2004 commented Mar 1, 2024

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

CCExtractor uses rsmpeg for FFmpeg bindings and we need to update it to the latest version.
I tried building CCExtractor with rsmpeg 0.14.2 + ffmpeg.6.1 and it was successfull.
Also I tested couple of videos with hardsubx flags and it is working fine.

This work was mentioned to be done in GSOC but since I didn't find anything lot to work, so doing it before

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 2ada36d...:

Report Name Tests Passed
Broken 12/13
CEA-708 14/14
DVB 4/7
DVD 3/3
DVR-MS 2/2
General 16/27
Hauppage 1/3
MP4 2/3
NoCC 10/10
Options 82/86
Teletext 21/21
WTV 9/13
XDS 27/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

@IshanGrover2004
Copy link
Contributor Author

@PunitLodha No problem here

@cfsmp3 cfsmp3 self-requested a review March 3, 2024 16:57
@cfsmp3 cfsmp3 merged commit 89a12a7 into CCExtractor:master Mar 3, 2024
15 checks passed
@IshanGrover2004 IshanGrover2004 deleted the bump-rsmpeg-version branch May 11, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants