Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Rustfmt CI failing #1598

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

prateekmedia
Copy link
Member

@prateekmedia prateekmedia commented Feb 4, 2024

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Cherry-picked from #1547 commit bd68411

@prateekmedia prateekmedia requested a review from cfsmp3 February 4, 2024 17:03
@IshanGrover2004
Copy link
Contributor

I was about to make PR for same and did commit in my fork (commit) 😀

@prateekmedia
Copy link
Member Author

@IshanGrover2004 I thought a standalone PR was required so extracted this from my previous PR as it is breaking CI from long time.

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit c550726...:

Report Name Tests Passed
Broken 12/13
CEA-708 14/14
DVB 4/7
DVD 3/3
DVR-MS 2/2
General 16/27
Hauppage 1/3
MP4 2/3
NoCC 10/10
Options 82/86
Teletext 21/21
WTV 9/13
XDS 27/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

@canihavesomecoffee canihavesomecoffee merged commit f449d06 into CCExtractor:master Feb 4, 2024
15 checks passed
@prateekmedia prateekmedia deleted the mybranch branch February 4, 2024 18:57
IshanGrover2004 pushed a commit to IshanGrover2004/ccextractor-fork that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants