-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add SCC support to CEA-708 decoder #1595
[FEATURE] Add SCC support to CEA-708 decoder #1595
Conversation
This PR is ready to review @PunitLodha |
@IshanGrover2004 The SCC captions generated do not work well for the fixing the original issue #1423. Did you try fixing captions for the video provided there? #1423 (comment) |
Yeah, I tested that & that is because the captions are currently get overlapping in it & I did push the solution for overlapping but maybe problem occurs in generating captions |
Hey @PunitLodha I did test and do some research and here is what i got |
97a2698
to
69155ee
Compare
Where did you get the correct SCC from? According to the original issue, this one seems to be correct, #1426 (comment) |
I don't remember the tool name but i have run it & its running correctly |
by adding necessary labels needed for it
by adding necessary labels needed for it
0d75727
to
9f8991a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work🎉
Anything else left @PunitLodha ? |
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit deaa4a6...:
All tests passing on the master branch were passed completely. NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
Check the result page for more info. |
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit f449d06...:
All tests passing on the master branch were passed completely. NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
Check the result page for more info. |
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
I have tested some of the videos and it is working.
Closes #1426 (and in order to fix #1423)