Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add SCC support to CEA-708 decoder #1595

Merged
merged 16 commits into from
Feb 18, 2024

Conversation

IshanGrover2004
Copy link
Contributor

@IshanGrover2004 IshanGrover2004 commented Feb 1, 2024

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

I have tested some of the videos and it is working.
Closes #1426 (and in order to fix #1423)

@cfsmp3 cfsmp3 requested a review from PunitLodha February 2, 2024 19:03
@IshanGrover2004
Copy link
Contributor Author

IshanGrover2004 commented Feb 4, 2024

This PR is ready to review @PunitLodha
if any suggestion, then let me know

@PunitLodha
Copy link
Member

@IshanGrover2004 The SCC captions generated do not work well for the fixing the original issue #1423. Did you try fixing captions for the video provided there? #1423 (comment)

@IshanGrover2004
Copy link
Contributor Author

IshanGrover2004 commented Feb 4, 2024

The SCC captions generated do not work well for the fixing the original issue #1423. Did you try fixing captions for the video provided there? #1423 (comment)

Yeah, I tested that & that is because the captions are currently get overlapping in it & I did push the solution for overlapping but maybe problem occurs in generating captions
I'll try to solve this by looking the correct SCC caption and my generated one & get back to you

@IshanGrover2004
Copy link
Contributor Author

Hey @PunitLodha I did test and do some research and here is what i got
Captions is perfectly made, its just because of formatting issues
And here is the diff of correct scc and scc generated by my code. Do have a look once. Do you know how can i decide using code when i need to place things like 94f2 94f2 to move cursor to row 15, column 4 ?

@IshanGrover2004 IshanGrover2004 force-pushed the feature-support-scc-format branch from 97a2698 to 69155ee Compare February 6, 2024 19:48
@PunitLodha
Copy link
Member

And here is the diff of correct scc and scc generated by my code.

Where did you get the correct SCC from? According to the original issue, this one seems to be correct, #1426 (comment)

@IshanGrover2004
Copy link
Contributor Author

IshanGrover2004 commented Feb 11, 2024

Where did you get the correct SCC from? According to the original issue, this one seems to be correct, #1426 (comment)

I don't remember the tool name but i have run it & its running correctly
And the comment has incomplete captions

@IshanGrover2004 IshanGrover2004 force-pushed the feature-support-scc-format branch from 0d75727 to 9f8991a Compare February 17, 2024 15:23
Copy link
Member

@PunitLodha PunitLodha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work🎉

@IshanGrover2004
Copy link
Contributor Author

Anything else left @PunitLodha ?

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit deaa4a6...:

Report Name Tests Passed
Broken 12/13
CEA-708 14/14
DVB 4/7
DVD 3/3
DVR-MS 2/2
General 16/27
Hauppage 1/3
MP4 3/3
NoCC 10/10
Options 82/86
Teletext 21/21
WTV 13/13
XDS 27/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit f449d06...:

Report Name Tests Passed
Broken 13/13
CEA-708 14/14
DVB 4/7
DVD 3/3
DVR-MS 2/2
General 24/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 84/86
Teletext 21/21
WTV 8/13
XDS 34/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

@cfsmp3 cfsmp3 merged commit 2ada36d into CCExtractor:master Feb 18, 2024
17 checks passed
@IshanGrover2004 IshanGrover2004 deleted the feature-support-scc-format branch February 19, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants