Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Hero Tag Conflict in FloatingActionButton #221

Closed
wants to merge 9 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"
apply from: project(':flutter_config').projectDir.getPath() + "/dotenv.gradle"

android {
compileSdkVersion 31
compileSdkVersion 33
buildToolsVersion '29.0.0'

sourceSets {
Expand Down
14 changes: 14 additions & 0 deletions ios/Flutter/Generated 2.xcconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// This is a generated file; do not edit or check into version control.
FLUTTER_ROOT=/Users/vipinkumar/fvm/versions/3.7.12
FLUTTER_APPLICATION_PATH=/Users/vipinkumar/Desktop/Beacon/beacon
COCOAPODS_PARALLEL_CODE_SIGN=true
FLUTTER_TARGET=lib/main.dart
FLUTTER_BUILD_DIR=build
FLUTTER_BUILD_NAME=1.0.0
FLUTTER_BUILD_NUMBER=1
EXCLUDED_ARCHS[sdk=iphonesimulator*]=i386
EXCLUDED_ARCHS[sdk=iphoneos*]=armv7
DART_OBFUSCATION=false
TRACK_WIDGET_CREATION=true
TREE_SHAKE_ICONS=false
PACKAGE_CONFIG=.dart_tool/package_config.json
3 changes: 2 additions & 1 deletion lib/components/hike_screen_widget.dart
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ class HikeScreenWidget extends ChangeNotifier {

static Widget shareButton(BuildContext context, String passkey) {
return FloatingActionButton(
heroTag: 'shareRouteTag',
onPressed: () {
showDialog(
context: context,
Expand Down Expand Up @@ -105,7 +106,7 @@ class HikeScreenWidget extends ChangeNotifier {
) {
return FloatingActionButton(
heroTag:
'shareRouteTag', //had to pass this tag else we would get error since there will be two FAB in the same subtree with the same tag.
'shareRouteTag1', //had to pass this tag else we would get error since there will be two FAB in the same subtree with the same tag.
onPressed: () async {
final mapController = await googleMapControllerCompleter.future;
// sanity check.
Expand Down
Loading