Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRDCDH 1599 #216

Open
wants to merge 3 commits into
base: 3.2.0
Choose a base branch
from
Open

CRDCDH 1599 #216

wants to merge 3 commits into from

Conversation

vshand11
Copy link
Collaborator

Implemented CRDCDH-1599 to pull synonyms from dump file stored in Github.

@vshand11 vshand11 requested a review from n2iw January 17, 2025 15:18
n2iw
n2iw requested changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@n2iw n2iw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good. Please merge the synonym pulling code into the "pv_puller" service, instead of creating a new service, thanks!

@vshand11
Copy link
Collaborator Author

The logic looks good. Please merge the synonym pulling code into the "pv_puller" service, instead of creating a new service, thanks!
updated and passed testing on both pullers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2iw n2iw n2iw requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vshand11 @n2iw