Test cases updates for NCCR, VIBE, OA Intake #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfcabrera14
reviewed
Jan 21, 2025
| @@ -91,15 +91,14 @@ Feature: Create OA Intake form | |||
| And User logs out of OA Intake application | |||
|
|
|||
| @selenium @Alena @Regression @OAIntake-332 @OAIntake-670 @OAIntake-669 | |||
|
|
|||
There was a problem hiding this comment.
extra blank space on line 94
| @Given("User can verify page header is {string}") | ||
| public void user_can_verify_page_header_is(String header) { | ||
| softAssert.assertEquals(oaIntakePage.leadershipQueuePageHeader.getText(), header); | ||
| oaIntakeStepsImplementation.verifyHeadrDisplayed(header); |
There was a problem hiding this comment.
missing javadoc statement for this method
There was a problem hiding this comment.
seems like the existing Javadoc has been removed:
/**
* verify Requestor (Requested For) Queue tab is displayed
*/
| @@ -8,6 +8,8 @@ | |||
| import com.nci.automation.web.CommonUtils; | |||
| import com.nci.automation.web.WebDriverUtils; | |||
| import org.testng.Assert; | |||
|
|
|||
There was a problem hiding this comment.
extra space on line 11
| @@ -67,6 +67,11 @@ public class AwardNominationPage { | |||
| @FindBy(xpath = "//span[.=' Tickets ']") | |||
| public WebElement sectionTickets; | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
extra space on line 70
hamidnesar
requested changes
Jan 21, 2025
| @Given("User can verify page header is {string}") | ||
| public void user_can_verify_page_header_is(String header) { | ||
| softAssert.assertEquals(oaIntakePage.leadershipQueuePageHeader.getText(), header); | ||
| oaIntakeStepsImplementation.verifyHeadrDisplayed(header); |
There was a problem hiding this comment.
seems like the existing Javadoc has been removed:
/**
* verify Requestor (Requested For) Queue tab is displayed
*/
| And User can verify Optional Responses option "In My Own Words - A text box will appear below when checked." is displayed | ||
|
|
||
|
|
There was a problem hiding this comment.
Please remove the empty line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.