Clean up #1009
Merged
Clean up #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
launch jenkins |
jonasjucker
reviewed
Oct 24, 2024
jonasjucker
reviewed
Oct 24, 2024
requirements.txt
Outdated
There was a problem hiding this comment.
I prefer to have this file back, see above
There was a problem hiding this comment.
It would be empty.
requests is no longer used.
pytest-xdist is an optional plugin to pytest, which one can use to run tests distributed, in parallel.
Would you like to have pytest-xdist back?
There was a problem hiding this comment.
Yes that would be nice
jonasjucker
requested changes
Oct 24, 2024
jonasjucker
reviewed
Oct 24, 2024
docs/UpstreamManagement.rst
Outdated
There was a problem hiding this comment.
I just realized that this entire section is obsolete. We don't use Upstreams anymore, hence the entire file can be deleted.
|
launch jenkins |
|
@jonasjucker Thanks for the good review. Would you mind having an other look at this PR? I tried to address all your suggestions. |
jonasjucker
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.