-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nabla2_...damping refactoring and some stencil tests' xfails cleanup #562
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, for the tests why don't you use the Output
class from test_utils.helpers
to restrict the comparison domain? I think that was introduced exactly for that.
In the diffusion: mostly revise the field allocations that you do.
model/atmosphere/diffusion/src/icon4py/model/atmosphere/diffusion/diffusion_utils.py
Outdated
Show resolved
Hide resolved
model/atmosphere/diffusion/src/icon4py/model/atmosphere/diffusion/diffusion.py
Outdated
Show resolved
Hide resolved
model/atmosphere/diffusion/src/icon4py/model/atmosphere/diffusion/diffusion.py
Outdated
Show resolved
Hide resolved
model/atmosphere/diffusion/src/icon4py/model/atmosphere/diffusion/diffusion.py
Outdated
Show resolved
Hide resolved
model/atmosphere/diffusion/src/icon4py/model/atmosphere/diffusion/diffusion.py
Outdated
Show resolved
Hide resolved
...tmosphere/diffusion/tests/diffusion_stencil_tests/test_apply_diffusion_to_theta_and_exner.py
Show resolved
Hide resolved
...tmosphere/diffusion/tests/diffusion_stencil_tests/test_apply_diffusion_to_theta_and_exner.py
Show resolved
Hide resolved
model/atmosphere/diffusion/tests/diffusion_stencil_tests/test_apply_diffusion_to_vn.py
Show resolved
Hide resolved
model/atmosphere/diffusion/tests/diffusion_stencil_tests/test_apply_diffusion_to_vn.py
Show resolved
Hide resolved
model/atmosphere/diffusion/tests/diffusion_stencil_tests/test_calculate_nabla2_for_z.py
Outdated
Show resolved
Hide resolved
…ion/diffusion_utils.py Co-authored-by: Magdalena <[email protected]>
…ion/diffusion.py Co-authored-by: Magdalena <[email protected]>
…ion/diffusion.py Co-authored-by: Magdalena <[email protected]>
…ion/diffusion.py Co-authored-by: Magdalena <[email protected]>
cscs-ci run default |
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
launch jenkins spack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…562) * refactoring of init_nabla2_factor_in_upper_damping_zone to a gt4py stencil * removal of some xfail in stencils tests
refactoring of
init_nabla2_factor_in_upper_damping_zone
to a gt4py stencilremoval of:
and consequent changes