Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nabla2_...damping refactoring and some stencil tests' xfails cleanup #562

Merged
merged 18 commits into from
Oct 8, 2024

Conversation

nfarabullini
Copy link
Contributor

@nfarabullini nfarabullini commented Oct 2, 2024

refactoring of init_nabla2_factor_in_upper_damping_zone to a gt4py stencil

removal of:

        if isinstance(grid, IconGrid) and grid.limited_area:
            pytest.xfail(
                "Execution domain needs to be restricted or boundary taken into account in stencil."
            )

and consequent changes

@nfarabullini nfarabullini changed the title init_nabla2_factor_in_upper_damping_zone refactoring nabla2_...damping refactoring and some stencil tests' xfails cleanup Oct 2, 2024
@nfarabullini nfarabullini requested a review from halungge October 2, 2024 20:19
Copy link
Contributor

@halungge halungge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, for the tests why don't you use the Output class from test_utils.helpers to restrict the comparison domain? I think that was introduced exactly for that.

In the diffusion: mostly revise the field allocations that you do.

@nfarabullini
Copy link
Contributor Author

cscs-ci run default

Copy link

github-actions bot commented Oct 4, 2024

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@nfarabullini
Copy link
Contributor Author

launch jenkins spack

@nfarabullini nfarabullini requested a review from halungge October 4, 2024 09:42
Copy link
Contributor

@halungge halungge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nfarabullini nfarabullini merged commit 8d14f80 into main Oct 8, 2024
5 checks passed
OngChia pushed a commit that referenced this pull request Jan 14, 2025
…562)

* refactoring of init_nabla2_factor_in_upper_damping_zone to a gt4py stencil

* removal of some xfail in stencils tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants