Git Tools integration #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andyspiros can you review this? |
| else | ||
| if [[ -z ${host} ]]; then | ||
| exitError 654 ${LINENO} "host is not defined" | ||
| fi | ||
| # workaround for Todi, Daint, and Lema | ||
| # workaround for Todi, Daint, and Lema | ||
| if [ "${host}" == "lema" -o "${host}" == "todi" -o "${host}" == "daint" ] ; then |
There was a problem hiding this comment.
This file already exists on svn.
| if [ -z "${path}" ] ; then | ||
| path=$(pwd) | ||
| fi | ||
| echo $(git -C "${path}" branch 2> /dev/null | sed -n '/^\*/s/^\* //p') |
There was a problem hiding this comment.
git -C $path rev-parse --abbrev-ref HEAD is probably easier.
|
I'm done with the review. I suppose you tested it all, right? It's fine from my point of view. Just consider those few question I asked, then you can merge. |
|
Great thank you! I added these changes:
I further expanded my test function to test the implementation ;) |
|
I removed the function call to the test function to avoid showing the selftest every time the function is run ; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.