-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement TCP checks #17
Open
coolacid
wants to merge
2
commits into
Bullrich:main
Choose a base branch
from
coolacid:CheckTypes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,95 @@ | ||
import * as net from 'net'; | ||
import { ActionLogger } from "../github/types"; | ||
|
||
function attemptConnection(host: string, port: number, logger: ActionLogger, retryCount: number = 5): Promise<boolean> { | ||
return new Promise((resolve) => { | ||
let attempts = 0; | ||
|
||
function attemptConnection() { | ||
const socket = new net.Socket(); | ||
|
||
// Set a timeout for the connection attempt | ||
socket.setTimeout(1000); | ||
|
||
// Attempt to connect to the specified host and port | ||
socket.on('connect', () => { | ||
// If connected, destroy the socket and resolve true | ||
socket.removeAllListeners(); // Clean up listeners | ||
socket.destroy(); | ||
resolve(true); | ||
|
||
}); | ||
|
||
// Handle errors that occur during the connection attempt | ||
socket.on('error', (err) => { | ||
logger.error(`Connection error: ${err.message}`); | ||
socket.removeAllListeners(); | ||
socket.destroy(); | ||
// If it's anything other then a connection refused, retry | ||
if (!err.message.includes("ECONNREFUSED")) { | ||
handleRetry(); | ||
} else { | ||
resolve(false); // Resolve the promise on ECONNREFUSED | ||
} | ||
}); | ||
|
||
// Handle timeout scenario | ||
socket.on('timeout', () => { | ||
logger.error('Connection timeout'); | ||
socket.destroy(); | ||
resolve(false); | ||
}); | ||
|
||
function handleRetry() { | ||
if (attempts < retryCount) { | ||
attempts += 1; | ||
logger.info(`Retrying... (${attempts}/${retryCount})`); | ||
setTimeout(attemptConnection, 500); // Retry after .5 seconds | ||
} else { | ||
resolve(false); // Failed after retrying | ||
} | ||
} | ||
|
||
socket.connect(port, host); | ||
} | ||
|
||
attemptConnection(); | ||
|
||
}); | ||
} | ||
|
||
export class TCPChecker { | ||
constructor(private readonly siteName: string, private readonly healthEndpoint: string, | ||
private readonly logger: ActionLogger) { | ||
this.logger.info(`Created Status Checker for ${siteName}`); | ||
} | ||
|
||
async verifyEndpoint(): Promise<boolean> { | ||
const [host, portString] = this.healthEndpoint.replace('tcp://', '').split(':'); | ||
if (!host) { | ||
this.logger.error('Invalid host: Host cannot be empty'); | ||
return false; | ||
} | ||
|
||
// Convert the port part to a number | ||
const port = parseInt(portString, 10); | ||
if (Number.isNaN(port) || port < 1 || port > 65535) { | ||
this.logger.error(`Invalid port number: ${portString}`); | ||
return false; | ||
} | ||
|
||
try { | ||
const isConnected = await attemptConnection(host, port, this.logger); | ||
if (isConnected) { | ||
this.logger.info('Connection successful'); | ||
return true; | ||
} else { | ||
this.logger.info('Connection failed'); | ||
return false; | ||
} | ||
} catch (error) { | ||
this.logger.error('Error during connection attempt: ' + error); | ||
return false; | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
The current endpoints raise reliability concerns:
neverssl.com
) is a static page last modified in 2022, designed for captive portal testingtcpbin.com
) is a public service without guaranteed availabilityRecommendations:
🔗 Analysis chain
Review reliability of test endpoints.
The current test endpoints raise some concerns:
neverssl.com
is primarily designed for captive portal testing, not for production health checkstcpbin.com
is a third-party service that might have:Consider using:
Run this script to check the reliability of the current endpoints:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 494
Script:
Length of output: 1399