Fixed closed incidents being ignored (#13)

Fixed bug where closed incidents wouldn't appear. Also added extra workflow trigger to the health check. Now it will run on the creation of an issue (so it can respond faster to incidents)
Bullrich · Aug 7, 2024 · c586313 · c586313
1 parent f4f3a0a
commit c586313
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.github/workflows/health-check.yml b/.github/workflows/health-check.yml
@@ -6,6 +6,8 @@ on:
   workflow_dispatch:
   schedule:
     - cron: '0 */2 * * *'
+  issues:
+    types: [opened, closed]
 
 env:
   ARTIFACT_NAME: reports

diff --git a/log/src/github/incidents.ts b/log/src/github/incidents.ts
@@ -12,7 +12,7 @@ export class IncidentManager {
 
     async obtainPastIncidents(repo: Repo, maxAge: number): Promise<ReportFile["incidents"]> {
         this.logger.info("Searching for previous incidents")
-        const issues = await this.api.rest.issues.listForRepo({ ...repo });
+        const issues = await this.api.rest.issues.listForRepo({ ...repo, state: "all" });
         this.logger.info(`Found ${issues.data.length} issues`);
         const incidents: ReportFile["incidents"] = []