Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bound media query styles are not converted to strings #1651

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Dec 5, 2024

Description

Bound media query styles in the Builder parser are incorrectly transformed into strings. This means that color: state.color becomes color: "state.color" and the color prop on an element is set to the "state.color" string literal instead of being evaluated to the value of state.color.

This PR fixes the issue by ensuring that bound values remain bound and are not converted to strings.

Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:

  • format the codebase: from the root, run yarn fmt:prettier.
  • update all snapshots (in core & CLI): from the root, run yarn test:update
  • add Changeset entry: from the root, run yarn g:changeset and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.

Copy link

changeset-bot bot commented Dec 5, 2024

🦋 Changeset detected

Latest commit: 490db32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@builder.io/mitosis Patch
@builder.io/mitosis-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@liamdebeasi liamdebeasi marked this pull request as ready for review December 5, 2024 22:54
Copy link

nx-cloud bot commented Dec 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 490db32. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@liamdebeasi liamdebeasi merged commit d52fe59 into BuilderIO:main Dec 6, 2024
8 checks passed
@liamdebeasi liamdebeasi deleted the ld/mitosis-binding-fix branch December 6, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants