Fixed Double Tap and Drag #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmatth
requested changes
Mar 29, 2023
There was a problem hiding this comment.
You're in the right part of the code base but there's currently a bug where the base will change as you move through other text nodes:
2023-03-29_15-33-28.mp4
I'm pretty sure the issue is that the logic on line 571 only compares offsets, without considering whether those positions exist within the same block.
jmatth
requested changes
Apr 5, 2023
super_editor/lib/src/default_editor/document_gestures_mouse.dart
Outdated
Show resolved
Hide resolved
jmatth
force-pushed
the
cc-custom
branch
2 times, most recently
from
ba79005 to
1dcbc18
Compare
jmatth
force-pushed
the
cc-custom
branch
2 times, most recently
from
6d0e7fc to
ebdd0be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.