Fixing the customer option factory

Brille24 · Oct 25, 2021 · 684975a · 684975a
1 parent 347ad32
commit 684975a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/Factory/OrderItemOptionFactory.php b/src/Factory/OrderItemOptionFactory.php
@@ -97,15 +97,15 @@ public function createForOptionAndValue(
     public function createNewFromStrings(
         OrderItemInterface $orderItem,
         string $customerOptionCode,
-        string $customerOptionValue
+        $customerOptionValue
     ): OrderItemOptionInterface {
         $customerOption = $this->customerOptionRepository->findOneByCode($customerOptionCode);
         if ($customerOption === null) {
             throw new Exception('Could not find customer option with code');
         }
 
         if (CustomerOptionTypeEnum::isSelect($customerOption->getType())) {
-            $customerOptionValue = $this->valueResolver->resolve($customerOption, $customerOptionValue);
+            $customerOptionValue = $this->valueResolver->resolve($customerOption, (string) $customerOptionValue);
         }
 
         return $this->createForOptionAndValue($orderItem, $customerOption, $customerOptionValue);

diff --git a/src/Factory/OrderItemOptionFactoryInterface.php b/src/Factory/OrderItemOptionFactoryInterface.php
@@ -21,7 +21,7 @@ interface OrderItemOptionFactoryInterface
     /**
      * @param CustomerOptionInterface $customerOption
      * @param mixed                   $customerOptionValue
-     * @param OrderItemInterface $orderItem
+     * @param OrderItemInterface      $orderItem
      *
      * @return OrderItemOptionInterface
      */
@@ -34,15 +34,15 @@ public function createForOptionAndValue(
     /**
      * Creates an OrderItemOption based on the two input strings
      *
-     * @param string $customerOptionCode The code of teh customer option
-     * @param string $customerOptionValue The code of the value if it is a select else just the value itself
-     * @param OrderItemInterface $orderItem
+     * @param string              $customerOptionCode The code of teh customer option
+     * @param mixed               $customerOptionValue The code of the value if it is a select else just the value itself
+     * @param OrderItemInterface  $orderItem
      *
      * @return OrderItemOptionInterface
      */
     public function createNewFromStrings(
         OrderItemInterface $orderItem,
         string $customerOptionCode,
-        string $customerOptionValue
+        $customerOptionValue
     ): OrderItemOptionInterface;
 }