Skip to content

Commit

Permalink
whoops, change infinite dilution val
Browse files Browse the repository at this point in the history
  • Loading branch information
Boxylmer committed Nov 19, 2023
1 parent 689bdb6 commit 3647a63
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "SorptionModels"
uuid = "44adabc6-386d-4db0-bb6e-0f7b06129544"
authors = ["Will <[email protected]> and contributors"]
version = "0.1.54"
version = "0.1.55"

[deps]
DelimitedFiles = "8bb1440f-4735-579b-a4ab-409b98df4dab"
Expand Down
2 changes: 1 addition & 1 deletion src/ModelAnalyses/IsostericHeatOfSorption.jl
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ function IsostericHeatAnalysis(isotherms::AbstractVector{<:IsothermData}, eosmod
isotherm_concentration_vectors = [concentration(isotherm; component=1) for isotherm in isotherms]
max_concentration = minimum([isotherm_concentration_vector[end] for isotherm_concentration_vector in isotherm_concentration_vectors])
# and pick a set of concentrations to sample at below that maximum
sampled_concentrations = LinRange(1e-3, max_concentration, num_points)
sampled_concentrations = LinRange(1e-1, max_concentration, num_points)
# calculate the interpolated pressure curves and their logarithms (Base e)
pressure_curves = [predict_pressure.(sorption_models, conc) for conc in sampled_concentrations]
ln_pressure_curves = [log.(pressure_curve) for pressure_curve in pressure_curves]
Expand Down
4 changes: 2 additions & 2 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -509,8 +509,8 @@ precision = 5
conc_no_constraint = ish_analysis.sampled_concentrations[4]
conc_with_constraint = ish_analysis_but_with_vhdm.sampled_concentrations[4]
@test conc_no_constraint == conc_with_constraint
@test ish_analysis.isosteric_heat_at_conc[4].val -18808.52702744859
@test ish_analysis_but_with_vhdm.isosteric_heat_at_conc[4].val -18118.53623433742
@test ish_analysis.isosteric_heat_at_conc[4].val -18815.424127650764
@test ish_analysis_but_with_vhdm.isosteric_heat_at_conc[4].val -18121.602388309566
end

@testset "Webb Isosteric Heat Analysis" begin
Expand Down

2 comments on commit 3647a63

@Boxylmer
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/95623

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.1.55 -m "<description of version>" 3647a634c1eadc3e5ff25adb4f805a1cd6cba58e
git push origin v0.1.55

Please sign in to comment.