Hide most functions/global variables. #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Global struct instance must be `static`. One reason is `SUFFIX nothing` which would otherwise cause symbols to clash. Similarly, any function that isn't `dlsym`ed or eligible for `EXTERNAL` should have internal linkage.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Oct 15, 2024
1uc
force-pushed
the
1uc/more-internal-linkage
branch
from
4e59661 to
bd4774a
Compare
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Oct 15, 2024
|
It doesn't quite catch all of them, and we'll want to move to anonymous namespace; but it does solve the problem for NRN unit-tests. |
alkino
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global struct instance must be
static. One reason isSUFFIX nothingwhich would otherwise cause symbols to clash.Similarly, any function that isn't
dlsymed or eligible forEXTERNALshould have internal linkage.