Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix returning reference to local object. #1102

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Dec 1, 2023

No description provided.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5bae4d0) 88.18% compared to head (2a5b9a5) 88.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1102      +/-   ##
==========================================
- Coverage   88.18%   88.17%   -0.01%     
==========================================
  Files         175      175              
  Lines       12905    12907       +2     
==========================================
+ Hits        11380    11381       +1     
- Misses       1525     1526       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #176538 (:white_check_mark:) have been uploaded here!

Status and direct links:

@1uc 1uc marked this pull request as ready for review December 1, 2023 14:15
@1uc 1uc requested a review from tristan0x December 4, 2023 13:24
Copy link
Member

@tristan0x tristan0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dear! Well spotted! Thank you @1uc

@1uc 1uc merged commit 474c3fe into master Dec 5, 2023
16 of 17 checks passed
@1uc 1uc deleted the 1uc/fix-reference-to-local-obj branch December 5, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants