Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation of generated MOD file for NEURON #1101

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

iomaganaris
Copy link
Contributor

  • Added missing ; in instantiation of slist/dlist
  • Use a variable name for the channel info array that doesn't clash with other NEURON declarations
  • Fix use of mech_type variable in NEURON code

@iomaganaris iomaganaris requested a review from 1uc November 30, 2023 12:33
@iomaganaris iomaganaris self-assigned this Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2c4c8e2) 88.18% compared to head (959d32c) 88.18%.

Files Patch % Lines
src/codegen/codegen_neuron_cpp_visitor.cpp 66.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1101   +/-   ##
=======================================
  Coverage   88.18%   88.18%           
=======================================
  Files         175      175           
  Lines       12903    12905    +2     
=======================================
+ Hits        11378    11380    +2     
  Misses       1525     1525           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #176019 (:white_check_mark:) have been uploaded here!

Status and direct links:

@iomaganaris iomaganaris merged commit 5bae4d0 into master Nov 30, 2023
16 of 17 checks passed
@iomaganaris iomaganaris deleted the magkanar/nrn_compile branch November 30, 2023 13:50
@iomaganaris iomaganaris added the NEURON codegen Work toward NEURON code generation label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NEURON codegen Work toward NEURON code generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants