More linting

[ssssarah]

• rm import from kgforge.commons.archetypes and kgforge.core and target specific files to avoid cyclic dependencies
• When catching an exception and re-raising a different one, raise from the one that was caught to keep the stack trace and facilitate debugging
• not_supported to return exception to be raised
• not_supported raised in specialisations, not core. In core, methods defined as abstract. Motivation: when implementing one of the archetypes, it's simpler to extend it and to have your IDE generate all abstract methods than it is to have them "implemented for you as not implemented" and having to go to the archetype definition to retrieve the method signatures to override. Moreover, it's better to have a complete visual of unimplemented functionality in one's specialisation, rather than to have to go back to the archetype to see methods that have yet to be implemented
• rm redefinition of constructor in subclasses if no additional logic is added
• rm raise Exception, raise more specific exceptions
• Raising linting threshold to 9.0

[codecov-commenter]

Codecov Report

Attention: 159 lines in your changes are missing coverage. Please review.

Comparison is base (4d2580e) 74.42% compared to head (16e50d1) 74.46%.

Files	Patch %	Lines
kgforge/specializations/stores/demo_store.py	30.76%	36 Missing ⚠️
kgforge/core/archetypes/model.py	51.61%	15 Missing ⚠️
kgforge/core/archetypes/resolver.py	62.96%	10 Missing ⚠️
kgforge/core/archetypes/store.py	52.38%	10 Missing ⚠️
kgforge/core/conversions/rdf.py	33.33%	8 Missing ⚠️
kgforge/specializations/models/demo_model.py	68.18%	7 Missing ⚠️
kgforge/core/archetypes/read_only_store.py	50.00%	6 Missing ⚠️
kgforge/specializations/models/rdf_model.py	66.66%	6 Missing ⚠️
kgforge/specializations/stores/bluebrain_nexus.py	60.00%	6 Missing ⚠️
kgforge/specializations/stores/sparql_store.py	45.45%	6 Missing ⚠️
... and 20 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
+ Coverage   74.42%   74.46%   +0.03%     
==========================================
  Files         100      100              
  Lines        6213     6293      +80     
==========================================
+ Hits         4624     4686      +62     
- Misses       1589     1607      +18     

Flag	Coverage Δ
unittests	74.46% <56.43%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[crisely09]

These are small but wide changes, can we merge this after the archetypes change?

[ssssarah]

These are small but wide changes, can we merge this after the archetypes change?

Yeah of course, archetypes > everything else

[crisely09]

Good with me.