Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archetypes for external datasets #353

Closed
wants to merge 19 commits into from
Closed

Archetypes for external datasets #353

wants to merge 19 commits into from

Conversation

crisely09
Copy link
Contributor

  • Add ReadStore
  • Make Store inherit ReadStore
  • Add ExternalDataset as ReadStore + other methods (types)

Missing:

  • forge methods to access external datasets
  • specializations
  • tests

@crisely09 crisely09 requested a review from ssssarah October 30, 2023 08:49
@crisely09 crisely09 requested a review from MFSY October 30, 2023 13:14
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Attention: 90 lines in your changes are missing coverage. Please review.

Comparison is base (9ffefac) 74.13% compared to head (d85ee1c) 73.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
- Coverage   74.13%   73.92%   -0.21%     
==========================================
  Files          93       97       +4     
  Lines        5919     6056     +137     
==========================================
+ Hits         4388     4477      +89     
- Misses       1531     1579      +48     
Flag Coverage Δ
unittests 73.92% <59.27%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
kgforge/core/archetypes/__init__.py 100.00% <100.00%> (ø)
kgforge/specializations/stores/bluebrain_nexus.py 28.63% <ø> (ø)
tests/conftest.py 98.98% <ø> (ø)
tests/core/archetypes/test_dataset_store.py 100.00% <100.00%> (ø)
tests/core/archetypes/test_read_only_store.py 100.00% <100.00%> (ø)
tests/core/archetypes/test_store.py 100.00% <100.00%> (ø)
...sts/specializations/stores/test_bluebrain_nexus.py 93.97% <100.00%> (+0.07%) ⬆️
kgforge/core/archetypes/store.py 69.56% <86.66%> (+10.20%) ⬆️
kgforge/specializations/stores/demo_store.py 41.01% <81.81%> (+1.59%) ⬆️
kgforge/core/forge.py 64.62% <62.50%> (-0.09%) ⬇️
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kgforge/core/archetypes/__init__.py Outdated Show resolved Hide resolved
kgforge/core/archetypes/__init__.py Outdated Show resolved Hide resolved
kgforge/core/archetypes/external_dataset.py Outdated Show resolved Hide resolved
kgforge/core/archetypes/read_store.py Outdated Show resolved Hide resolved
kgforge/core/archetypes/read_store.py Outdated Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
kgforge/core/archetypes/external_dataset.py Outdated Show resolved Hide resolved
kgforge/core/archetypes/external_dataset.py Outdated Show resolved Hide resolved
kgforge/core/archetypes/external_dataset.py Outdated Show resolved Hide resolved
kgforge/core/archetypes/external_dataset.py Outdated Show resolved Hide resolved
@crisely09 crisely09 requested a review from MFSY October 31, 2023 16:36
@crisely09
Copy link
Contributor Author

@MFSY you requested changes, this needs your approval anyway

offset: int = DEFAULT_OFFSET,
**params) -> Optional[Union[List[Resource], Resource]]:
...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add elastic method

f"No resource with content_type {content_type} was found when following the resource path '{follow}'."
)

def _download_many(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do download instead of one or many (same for the other methods)

@crisely09
Copy link
Contributor Author

Merged in the SPARQL store specialization

@crisely09 crisely09 closed this Nov 27, 2023
@crisely09 crisely09 deleted the dev-extsource branch November 27, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants