pycodestyle

[ssssarah]

Inspired by #237 , but on the more recent codebase.

[codecov-commenter]

Codecov Report

Attention: 138 lines in your changes are missing coverage. Please review.

Comparison is base (ab22a83) 74.30% compared to head (88cf0a9) 74.20%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
- Coverage   74.30%   74.20%   -0.10%     
==========================================
  Files          93       93              
  Lines        5934     5913      -21     
==========================================
- Hits         4409     4388      -21     
  Misses       1525     1525              

Flag	Coverage Δ
unittests	74.20% <59.17%> (-0.10%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
kgforge/core/__init__.py	100.00% <ø> (ø)
kgforge/core/archetypes/mapper.py	69.69% <ø> (ø)
kgforge/core/commons/actions.py	93.75% <ø> (ø)
kgforge/core/commons/attributes.py	72.22% <ø> (ø)
kgforge/core/commons/context.py	92.30% <100.00%> (ø)
kgforge/core/commons/dictionaries.py	72.72% <100.00%> (ø)
kgforge/core/commons/exceptions.py	100.00% <ø> (ø)
kgforge/core/commons/files.py	54.54% <100.00%> (ø)
kgforge/core/commons/formatter.py	100.00% <ø> (ø)
kgforge/core/commons/query_builder.py	81.25% <ø> (ø)
... and 47 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MFSY]

Inspired by #237 , but on the more recent codebase. Running tox -e lint led to many warnings. This is just addressing some of them. Maybe running the command should be done as job systematically (as proposed in the previously mentioned MR).

Please add the job.

[ssssarah]

Inspired by #237 , but on the more recent codebase. Running tox -e lint led to many warnings. This is just addressing some of them. Maybe running the command should be done as job systematically (as proposed in the previously mentioned MR).

Please add the job.

I've just added the job in the github workflows, but it only runs pycodestyle because I've fixed all pycodestyle errors, but I haven't fixed all pylint errors, so if added the pylint one it would fail

[crisely09]

It's fine with me. I will approve but let @MFSY have the last word.

[ssssarah]

Although I don't think it helps much, I've re-enabled pylint and added a threshold under which the job fails. The score should be above 8.5/10